commit 0df0082afacb01bf59ab0bc267fa12932503b805
author Tom Sepez <tsepez@chromium.org> Wed Oct 26 16:35:52 2022 +0000
committer Pdfium LUCI CQ <pdfium-scoped@luci-project-accounts.iam.gserviceaccount.com> Wed Oct 26 16:35:52 2022 +0000
tree fa61413f3754aeed481e9f03901d2f058a67ec41
parent ec350d928d4ec9398b98c3f835548f93f6b284d4

Add embedder test for FFL_ComboBox::GetSelectExportText()

Change-Id: If4dfd8d187ccf0b0a5ef9e52adfc7a67cfaf6409
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/100072
Commit-Queue: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>

fpdfsdk/formfiller/cffl_combobox.h

diff --git a/fpdfsdk/formfiller/cffl_combobox.h b/fpdfsdk/formfiller/cffl_combobox.h
index 724e6ac..2b1a306 100644
--- a/fpdfsdk/formfiller/cffl_combobox.h
+++ b/fpdfsdk/formfiller/cffl_combobox.h
@@ -55,8 +55,9 @@
   // CPWL_Wnd::ProviderIface:
   void OnSetFocusForEdit(CPWL_Edit* pEdit) override;
 
- private:
   WideString GetSelectExportText();
+
+ private:
   CPWL_ComboBox* GetPWLComboBox(const CPDFSDK_PageView* pPageView) const;
   CPWL_ComboBox* CreateOrUpdatePWLComboBox(const CPDFSDK_PageView* pPageView);
 

fpdfsdk/formfiller/cffl_combobox_embeddertest.cpp

diff --git a/fpdfsdk/formfiller/cffl_combobox_embeddertest.cpp b/fpdfsdk/formfiller/cffl_combobox_embeddertest.cpp
index 9201e78..7444692 100644
--- a/fpdfsdk/formfiller/cffl_combobox_embeddertest.cpp
+++ b/fpdfsdk/formfiller/cffl_combobox_embeddertest.cpp
@@ -9,7 +9,9 @@
 
 class CFFLComboBoxEmbedderTest : public CPWLComboBoxEmbedderTest {};
 
-TEST_F(CFFLComboBoxEmbedderTest, PlaceHolder) {
+TEST_F(CFFLComboBoxEmbedderTest, ExportText) {
   FormFillerAndWindowSetup(GetCPDFSDKAnnotNormal());
-  EXPECT_TRUE(GetCFFLFormField());
+  auto* pComboBox = static_cast<CFFL_ComboBox*>(GetCFFLFormField());
+  ASSERT_TRUE(pComboBox);
+  EXPECT_EQ(L"Banana", pComboBox->GetSelectExportText());
 }