commit 1d08c50d1c20798001a1944e8a1fd76d09643ef1
author tsepez <tsepez@chromium.org> Fri Nov 04 15:45:02 2016 -0700
committer Commit bot <commit-bot@chromium.org> Fri Nov 04 15:45:03 2016 -0700
tree 062d248591c5b201f00a50c09995e94c09794bc2
parent c5267c54ea32ade03bf10e6bb203e34e3fcbd77d

CHECK for re-addition of indirect objects

Review-Url: https://codereview.chromium.org/2471263005

core/fpdfapi/parser/cpdf_document_unittest.cpp

diff --git a/core/fpdfapi/parser/cpdf_document_unittest.cpp b/core/fpdfapi/parser/cpdf_document_unittest.cpp
index 71716a6..16d0ade 100644
--- a/core/fpdfapi/parser/cpdf_document_unittest.cpp
+++ b/core/fpdfapi/parser/cpdf_document_unittest.cpp
@@ -69,8 +69,7 @@
     CPDF_Dictionary* pagesDict = CreatePageTreeNode(allPages, this, 7);
 
     m_pOwnedRootDict.reset(new CPDF_Dictionary());
-    m_pOwnedRootDict->SetReferenceFor("Pages", this,
-                                      AddIndirectObject(pagesDict));
+    m_pOwnedRootDict->SetReferenceFor("Pages", this, pagesDict->GetObjNum());
     m_pRootDict = m_pOwnedRootDict.get();
     m_PageList.SetSize(7);
   }

core/fpdfapi/parser/cpdf_indirect_object_holder.cpp

diff --git a/core/fpdfapi/parser/cpdf_indirect_object_holder.cpp b/core/fpdfapi/parser/cpdf_indirect_object_holder.cpp
index d3204e0..720fe18 100644
--- a/core/fpdfapi/parser/cpdf_indirect_object_holder.cpp
+++ b/core/fpdfapi/parser/cpdf_indirect_object_holder.cpp
@@ -43,9 +43,7 @@
 }
 
 uint32_t CPDF_IndirectObjectHolder::AddIndirectObject(CPDF_Object* pObj) {
-  if (pObj->m_ObjNum)
-    return pObj->m_ObjNum;
-
+  CHECK(!pObj->m_ObjNum);
   m_LastObjNum++;
   m_IndirectObjs[m_LastObjNum].release();  // TODO(tsepez): stop this leak.
   m_IndirectObjs[m_LastObjNum].reset(pObj);