commit 36111e64c87cddeb3782215806235964a5f19620
author Tom Sepez <tsepez@chromium.org> Tue Jun 27 00:58:32 2023 +0000
committer Pdfium LUCI CQ <pdfium-scoped@luci-project-accounts.iam.gserviceaccount.com> Tue Jun 27 00:58:32 2023 +0000
tree 0659f604025ea2aaee479934bfa00debf2a76bf7
parent 4b06202b3df1dd17547f3034544688a5e34a7442

Fix search for colon in IsIsoTimeFormat()

Look for colon separator relative to index, not at fixed offset 2.
This has been wrong since at least 2018. Unfortunately, testing is
thin because IsoTime2Num test is disabled.

Change-Id: I7c06f900a9892ca9be10bcf3b674be33c8ee3d0e
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/109030
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Tom Sepez <tsepez@chromium.org>

fxjs/xfa/cfxjse_formcalc_context.cpp

diff --git a/fxjs/xfa/cfxjse_formcalc_context.cpp b/fxjs/xfa/cfxjse_formcalc_context.cpp
index 790ec94..695cc25 100644
--- a/fxjs/xfa/cfxjse_formcalc_context.cpp
+++ b/fxjs/xfa/cfxjse_formcalc_context.cpp
@@ -630,7 +630,7 @@
     if (FXSYS_atoi(szBuffer) > 60) {
       return false;
     }
-    if (pData[2] == ':') {
+    if (iIndex + 2 < iZone && pData[iIndex + 2] == ':') {
       if (iPos == 0) {
         iHour = FXSYS_atoi(szBuffer);
         ++iPos;
@@ -701,7 +701,7 @@
     if (FXSYS_atoi(szBuffer) > 60) {
       return false;
     }
-    if (pData[2] == ':') {
+    if (iIndex + 2 < pData.size() && pData[iIndex + 2] == ':') {
       if (iPos == 0) {
         iZoneHour = FXSYS_atoi(szBuffer);
       } else if (iPos == 1) {