commit 5cd9b7be1712eb478bd743ab61a99d8c4c87a5ee
author Lei Zhang <thestig@chromium.org> Sat Dec 11 01:06:08 2021 +0000
committer Pdfium LUCI CQ <pdfium-scoped@luci-project-accounts.iam.gserviceaccount.com> Sat Dec 11 01:06:08 2021 +0000
tree 69959d486dc40227c69875501408656ad71dac4d
parent f072514e04377d413ac70fcc25132fb8505326d9

Make CJS_Result::Error() return const-ref.

No need to construct a new WideString.

Change-Id: I73c955166fd8ecfbdaaefe9ba2de3252117d1860
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/87830
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>

fxjs/cjs_result.h

diff --git a/fxjs/cjs_result.h b/fxjs/cjs_result.h
index 9d007b5..d2265ac 100644
--- a/fxjs/cjs_result.h
+++ b/fxjs/cjs_result.h
@@ -39,7 +39,7 @@
   ~CJS_Result();
 
   bool HasError() const { return error_.has_value(); }
-  WideString Error() const { return error_.value(); }
+  const WideString& Error() const { return error_.value(); }
 
   bool HasReturn() const { return !return_.IsEmpty(); }
   v8::Local<v8::Value> Return() const { return return_; }