commit 7b75fbf64451562ccfa5eec690fb3d9698101f26
author Lei Zhang <thestig@chromium.org> Tue Sep 28 20:35:15 2021 +0000
committer Pdfium LUCI CQ <pdfium-scoped@luci-project-accounts.iam.gserviceaccount.com> Tue Sep 28 20:35:15 2021 +0000
tree dab85bac7b930a24548ab9d89e863a575157ad58
parent 35e5af3e98c6a62047c623f8cb49138701134ec8

Fix some build dependencies involving fxjs/cfx_v8.h.

- Since fxjs/cfx_v8.h includes core/fxcrt headers, //fxjs should have a
  public_deps entry for //core/fxcrt.
- //testing/fuzzers:fuzzer_init_public should have a dependency on
  //fxjs, since it includes cfx_v8.h.

Change-Id: I5d58ae0e18906739107d80620cee6d249a207d5a
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/85512
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>

fxjs/BUILD.gn

diff --git a/fxjs/BUILD.gn b/fxjs/BUILD.gn
index 82237e1..c6d7bca 100644
--- a/fxjs/BUILD.gn
+++ b/fxjs/BUILD.gn
@@ -17,6 +17,7 @@
   ]
   configs += [ "../:pdfium_strict_config" ]
   deps = [ "../core/fxcrt" ]
+  public_deps = []
   visibility = [ "../*" ]
 
   if (pdf_enable_v8) {
@@ -110,7 +111,10 @@
       "//v8:v8_libplatform",
     ]
     configs += [ "//v8:external_startup_data" ]
-    public_deps = [ "//v8" ]
+    public_deps += [
+      "../core/fxcrt",
+      "//v8",
+    ]
 
     if (pdf_enable_xfa) {
       sources += [

testing/fuzzers/BUILD.gn

diff --git a/testing/fuzzers/BUILD.gn b/testing/fuzzers/BUILD.gn
index 62539b3..85846c3 100644
--- a/testing/fuzzers/BUILD.gn
+++ b/testing/fuzzers/BUILD.gn
@@ -127,6 +127,7 @@
     configs += [ "//v8:external_startup_data" ]
     deps += [
       "../:test_support",
+      "../../fxjs",
       "//v8",
       "//v8:v8_libplatform",
     ]