commit ad650e327c5246dcb8705789a49e2276d7c35f4d
author Tom Sepez <tsepez@chromium.org> Tue Oct 26 18:11:17 2021 +0000
committer Pdfium LUCI CQ <pdfium-scoped@luci-project-accounts.iam.gserviceaccount.com> Tue Oct 26 18:11:17 2021 +0000
tree 6476db6abf1a7f472b7f1ae203b5212229006974
parent 5987b440e43038bca4ac13654a0457953381d87b

Comment on bShowWidget values in cpdfsdk_renderpage.cpp

I've tried to remove it (in error) as 'always false' perhaps 3 times
so far ...

Bug: pdfium:993
Change-Id: I908740de8215a4068812abca943659dc979387ab
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/86496
Commit-Queue: Tom Sepez <tsepez@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Auto-Submit: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>

fpdfsdk/cpdfsdk_renderpage.cpp

diff --git a/fpdfsdk/cpdfsdk_renderpage.cpp b/fpdfsdk/cpdfsdk_renderpage.cpp
index 2c71762..548f82c 100644
--- a/fpdfsdk/cpdfsdk_renderpage.cpp
+++ b/fpdfsdk/cpdfsdk_renderpage.cpp
@@ -70,9 +70,12 @@
     pContext->m_pAnnots = std::move(pOwnedList);
     bool bPrinting =
         pContext->m_pDevice->GetDeviceType() != DeviceType::kDisplay;
+
+    // TODO(https://crbug.com/pdfium/993) - maybe pass true here.
+    const bool bShowWidget = false;
     pList->DisplayAnnots(pPage, pContext->m_pDevice.get(),
-                         pContext->m_pContext.get(), bPrinting, matrix, false,
-                         nullptr);
+                         pContext->m_pContext.get(), bPrinting, matrix,
+                         bShowWidget, nullptr);
   }
 
   pContext->m_pRenderer = std::make_unique<CPDF_ProgressiveRenderer>(