commit b8df4c36dbe95395acbc2fbce7a190bcaac94e76
author Lei Zhang <thestig@chromium.org> Fri Jun 16 23:29:34 2023 +0000
committer Pdfium LUCI CQ <pdfium-scoped@luci-project-accounts.iam.gserviceaccount.com> Fri Jun 16 23:29:34 2023 +0000
tree 8f14c5a0db48933193fc5f2d51eb8543c787cfeb
parent 3e0aca45573b437bf1f4afee664d48a545cd20ce

Remove redundant MSVC 4267 warning

Change-Id: I9ff8405360e592522582ba68d30debd05e620d1d
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/104970
Commit-Queue: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>

BUILD.gn

diff --git a/BUILD.gn b/BUILD.gn
index 14c123b..c50a783 100644
--- a/BUILD.gn
+++ b/BUILD.gn
@@ -164,8 +164,7 @@
                     # signed/unsigned mismatch
 
         "/wd4267",  # 'var' : conversion from 'size_t' to 'type', possible loss
-                    # of
-                    # data
+                    # of data
 
         "/wd4305",  # 'identifier' : truncation from 'type1' to 'type2'
         "/wd4389",  # 'operator' : signed/unsigned mismatch
@@ -197,14 +196,6 @@
       ]
 
       if (current_cpu == "x86") {
-        cflags += [
-          # VC++ 2015 changes 32-bit size_t truncation warnings from 4244 to
-          # 4267. Example: short TruncTest(size_t x) { return x; }
-          # Since we disable 4244 we need to disable 4267 during migration.
-          # TODO(jschuh): crbug.com/167187 fix size_t to int truncations.
-          "/wd4267",
-        ]
-
         if (msvc_use_sse2) {
           cflags += [ "/arch:SSE2" ]
         }