commit c2ab68313c803730ae586ea780e46ba42de5a630
author Lei Zhang <thestig@chromium.org> Thu Nov 10 17:06:18 2022 +0000
committer Pdfium LUCI CQ <pdfium-scoped@luci-project-accounts.iam.gserviceaccount.com> Thu Nov 10 17:06:18 2022 +0000
tree a353143733a39f2204e575476935a15356411c5f
parent 1ed2d0bd9bd171debeee8d99c58183fcdfc56d13

Suppress GN check issues with Skia includes in fpdf_view*.cpp.

For some reason, gn check passes in standalone PDFium, but not in
Chromium. Add nogncheck comments to suppress the gn check errors.

Change-Id: Ia0a5753c8c58de741cfde535d789ff5139a3474c
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/101011
Reviewed-by: K. Moon <kmoon@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>

fpdfsdk/fpdf_view.cpp

diff --git a/fpdfsdk/fpdf_view.cpp b/fpdfsdk/fpdf_view.cpp
index 7a93f8e..8f244a9 100644
--- a/fpdfsdk/fpdf_view.cpp
+++ b/fpdfsdk/fpdf_view.cpp
@@ -53,8 +53,8 @@
 #include "third_party/base/span.h"
 
 #ifdef _SKIA_SUPPORT_
-#include "third_party/skia/include/core/SkPictureRecorder.h"
-#include "third_party/skia/include/core/SkRect.h"
+#include "third_party/skia/include/core/SkPictureRecorder.h"  // nogncheck
+#include "third_party/skia/include/core/SkRect.h"             // nogncheck
 #endif  // _SKIA_SUPPORT_
 
 #ifdef PDF_ENABLE_V8

fpdfsdk/fpdf_view_embeddertest.cpp

diff --git a/fpdfsdk/fpdf_view_embeddertest.cpp b/fpdfsdk/fpdf_view_embeddertest.cpp
index 0f3ccbd..c363100 100644
--- a/fpdfsdk/fpdf_view_embeddertest.cpp
+++ b/fpdfsdk/fpdf_view_embeddertest.cpp
@@ -28,16 +28,16 @@
 #include "third_party/base/check.h"
 
 #ifdef _SKIA_SUPPORT_
-#include "third_party/skia/include/core/SkCanvas.h"
-#include "third_party/skia/include/core/SkColor.h"
-#include "third_party/skia/include/core/SkColorType.h"
-#include "third_party/skia/include/core/SkImage.h"
-#include "third_party/skia/include/core/SkImageInfo.h"
-#include "third_party/skia/include/core/SkPicture.h"
-#include "third_party/skia/include/core/SkPictureRecorder.h"
-#include "third_party/skia/include/core/SkRefCnt.h"
-#include "third_party/skia/include/core/SkSize.h"
-#include "third_party/skia/include/core/SkSurface.h"
+#include "third_party/skia/include/core/SkCanvas.h"           // nogncheck
+#include "third_party/skia/include/core/SkColor.h"            // nogncheck
+#include "third_party/skia/include/core/SkColorType.h"        // nogncheck
+#include "third_party/skia/include/core/SkImage.h"            // nogncheck
+#include "third_party/skia/include/core/SkImageInfo.h"        // nogncheck
+#include "third_party/skia/include/core/SkPicture.h"          // nogncheck
+#include "third_party/skia/include/core/SkPictureRecorder.h"  // nogncheck
+#include "third_party/skia/include/core/SkRefCnt.h"           // nogncheck
+#include "third_party/skia/include/core/SkSize.h"             // nogncheck
+#include "third_party/skia/include/core/SkSurface.h"          // nogncheck
 #endif  // _SKIA_SUPPORT_
 
 using pdfium::ManyRectanglesChecksum;