commit c6e3d3c9d97dcf253ea4caee885545f5ca4bff90
author Tom Sepez <tsepez@chromium.org> Fri Aug 20 20:57:25 2021 +0000
committer Pdfium LUCI CQ <pdfium-scoped@luci-project-accounts.iam.gserviceaccount.com> Fri Aug 20 20:57:25 2021 +0000
tree d1b7781ff2b4829c018619361195151481494aba
parent ef48587a8af3e5868d54b8d5a38fe7deab309c2b

Remove CJS_Global::m_pFormFillEnv.

The member is unused, and as an observed ptr, does not change the
lifetime of the referenced object.

Change-Id: I54ef9cadaab879701b4103598db6f310b5579bd2
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/84271
Auto-Submit: Tom Sepez <tsepez@chromium.org>
Commit-Queue: Tom Sepez <tsepez@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>

fxjs/cjs_global.cpp

diff --git a/fxjs/cjs_global.cpp b/fxjs/cjs_global.cpp
index 0c44ad6..3aeb94f 100644
--- a/fxjs/cjs_global.cpp
+++ b/fxjs/cjs_global.cpp
@@ -11,7 +11,6 @@
 #include <vector>
 
 #include "core/fxcrt/fx_extension.h"
-#include "fpdfsdk/cpdfsdk_formfillenvironment.h"
 #include "fxjs/cfx_globaldata.h"
 #include "fxjs/cfx_keyvalue.h"
 #include "fxjs/cjs_event_context.h"
@@ -175,8 +174,6 @@
 
 CJS_Global::CJS_Global(v8::Local<v8::Object> pObject, CJS_Runtime* pRuntime)
     : CJS_Object(pObject, pRuntime) {
-  CPDFSDK_FormFillEnvironment* pFormFillEnv = GetRuntime()->GetFormFillEnv();
-  m_pFormFillEnv.Reset(pFormFillEnv);
   m_pGlobalData = CFX_GlobalData::GetRetainedInstance(nullptr);
   UpdateGlobalPersistentVariables();
 }

fxjs/cjs_global.h

diff --git a/fxjs/cjs_global.h b/fxjs/cjs_global.h
index a679229..6e7f5a7 100644
--- a/fxjs/cjs_global.h
+++ b/fxjs/cjs_global.h
@@ -92,7 +92,6 @@
 
   std::map<ByteString, std::unique_ptr<JSGlobalData>> m_MapGlobal;
   UnownedPtr<CFX_GlobalData> m_pGlobalData;
-  ObservedPtr<CPDFSDK_FormFillEnvironment> m_pFormFillEnv;
 };
 
 #endif  // FXJS_CJS_GLOBAL_H_