commit ec9f4970f777350af0c0c291eac2958f2ef9e5cc
author Tom Sepez <tsepez@chromium.org> Fri Jan 28 23:52:46 2022 +0000
committer Pdfium LUCI CQ <pdfium-scoped@luci-project-accounts.iam.gserviceaccount.com> Fri Jan 28 23:52:46 2022 +0000
tree 433ad2fbe86c15cce338ed881c76de4d327a4341
parent 6dd81921398c1a44abf4eac7ce04446efee74169

Remove CPDF_ContentMarks::DeleteLastMark()

It is uncalled. In turn, this makes MarkData::DeleteLastMark()
uncalled as well, so remove it too.

Change-Id: I832ed6f83a65b88ec2c445e6723d62dd649b2a7d
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/90090
Auto-Submit: Tom Sepez <tsepez@chromium.org>
Commit-Queue: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>

core/fpdfapi/page/cpdf_contentmarks.cpp

diff --git a/core/fpdfapi/page/cpdf_contentmarks.cpp b/core/fpdfapi/page/cpdf_contentmarks.cpp
index 1be8eb5..26ca7ac 100644
--- a/core/fpdfapi/page/cpdf_contentmarks.cpp
+++ b/core/fpdfapi/page/cpdf_contentmarks.cpp
@@ -73,15 +73,6 @@
     m_pMarkData = pdfium::MakeRetain<MarkData>();
 }
 
-void CPDF_ContentMarks::DeleteLastMark() {
-  if (!m_pMarkData)
-    return;
-
-  m_pMarkData->DeleteLastMark();
-  if (CountItems() == 0)
-    m_pMarkData.Reset();
-}
-
 size_t CPDF_ContentMarks::FindFirstDifference(
     const CPDF_ContentMarks* other) const {
   if (m_pMarkData == other->m_pMarkData)
@@ -165,8 +156,3 @@
   }
   return false;
 }
-
-void CPDF_ContentMarks::MarkData::DeleteLastMark() {
-  if (!m_Marks.empty())
-    m_Marks.pop_back();
-}

core/fpdfapi/page/cpdf_contentmarks.h

diff --git a/core/fpdfapi/page/cpdf_contentmarks.h b/core/fpdfapi/page/cpdf_contentmarks.h
index d13dc77..2715b85 100644
--- a/core/fpdfapi/page/cpdf_contentmarks.h
+++ b/core/fpdfapi/page/cpdf_contentmarks.h
@@ -37,7 +37,6 @@
                                    CPDF_Dictionary* pDict,
                                    const ByteString& property_name);
   bool RemoveMark(CPDF_ContentMarkItem* pMarkItem);
-  void DeleteLastMark();
   size_t FindFirstDifference(const CPDF_ContentMarks* other) const;
 
  private:
@@ -59,7 +58,6 @@
                                      CPDF_Dictionary* pDict,
                                      const ByteString& property_name);
     bool RemoveMark(CPDF_ContentMarkItem* pMarkItem);
-    void DeleteLastMark();
 
    private:
     std::vector<RetainPtr<CPDF_ContentMarkItem>> m_Marks;