commit 62ad9af8a9f9494645b659674b64bb51775cde05
author Lei Zhang <thestig@chromium.org> Tue Apr 12 18:28:43 2022 +0000
committer Pdfium LUCI CQ <pdfium-scoped@luci-project-accounts.iam.gserviceaccount.com> Tue Apr 12 18:28:43 2022 +0000
tree 739d5f15319bf4330089d859718764079af8506e
parent 95beb67b2405fd6e91d9fa5a22a82d848f5954de

Add a missing CFXJSE_ScopeUtil_IsolateHandleContext in CFXJSE_Engine.

Without it, CFXJSE_Engine::ResolveObjectsWithBindNode() can call into V8
without a v8::HandleScope.

Bug: chromium:1315203
Change-Id: I45bc1d0a59d2a2bcf9b9f748fd42ff398bf18f52
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/92530
Reviewed-by: Daniel Hosseinian <dhoss@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>

fxjs/xfa/cfxjse_engine.cpp

diff --git a/fxjs/xfa/cfxjse_engine.cpp b/fxjs/xfa/cfxjse_engine.cpp
index 8eacbdd..507b07b 100644
--- a/fxjs/xfa/cfxjse_engine.cpp
+++ b/fxjs/xfa/cfxjse_engine.cpp
@@ -697,6 +697,7 @@
   std::vector<cppgc::Member<CXFA_Object>> findObjects;
   findObjects.emplace_back(refObject ? refObject : m_pDocument->GetRoot());
   int32_t nNodes = 0;
+  CFXJSE_ScopeUtil_IsolateHandleContext scope(GetJseContext());
   while (true) {
     nNodes = fxcrt::CollectionSize<int32_t>(findObjects);
     int32_t i = 0;