commit edf817eed90f91e5966bff6863643fb785b7d875
author Tom Sepez <tsepez@chromium.org> Mon Aug 15 23:38:27 2022 +0000
committer Pdfium LUCI CQ <pdfium-scoped@luci-project-accounts.iam.gserviceaccount.com> Mon Aug 15 23:38:27 2022 +0000
tree 993be1a93cc1647570969881c90b3b4345c601d3
parent 06dd6504b534f109ac5c1fed2adad4e0455762a3

Mark CFWL_ThemeBackground as stack-allocated.

There are two sub-classes using implementation inheritance with
non-virtual destructors, so cleanup works as long as we always
know the actual type. Being stack-allocated ensures this.

Change-Id: I3ce51b929dc493fd2f7d215af5d2d35f8f2fe2b0
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/96517
Commit-Queue: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>

xfa/fwl/cfwl_themebackground.h

diff --git a/xfa/fwl/cfwl_themebackground.h b/xfa/fwl/cfwl_themebackground.h
index bb34f01..c252cf8 100644
--- a/xfa/fwl/cfwl_themebackground.h
+++ b/xfa/fwl/cfwl_themebackground.h
@@ -7,6 +7,7 @@
 #ifndef XFA_FWL_CFWL_THEMEBACKGROUND_H_
 #define XFA_FWL_CFWL_THEMEBACKGROUND_H_
 
+#include "core/fxcrt/fx_memory.h"
 #include "core/fxcrt/unowned_ptr.h"
 #include "xfa/fwl/cfwl_themepart.h"
 
@@ -15,6 +16,8 @@
 
 class CFWL_ThemeBackground final : public CFWL_ThemePart {
  public:
+  FX_STACK_ALLOCATED();
+
   CFWL_ThemeBackground(CFWL_Widget* pWidget, CFGAS_GEGraphics* pGraphics);
   ~CFWL_ThemeBackground();
 

xfa/fwl/cfwl_themepart.h

diff --git a/xfa/fwl/cfwl_themepart.h b/xfa/fwl/cfwl_themepart.h
index a49bc8e..e286620 100644
--- a/xfa/fwl/cfwl_themepart.h
+++ b/xfa/fwl/cfwl_themepart.h
@@ -10,6 +10,7 @@
 #include <stdint.h>
 
 #include "core/fxcrt/fx_coordinates.h"
+#include "core/fxcrt/fx_memory.h"
 #include "core/fxcrt/mask.h"
 #include "core/fxcrt/unowned_ptr.h"
 #include "xfa/fwl/theme/cfwl_utils.h"
@@ -81,6 +82,8 @@
     kWeekNumSep
   };
 
+  FX_STACK_ALLOCATED();
+
   explicit CFWL_ThemePart(CFWL_Widget* pWidget);
   ~CFWL_ThemePart();
 

xfa/fwl/cfwl_themetext.h

diff --git a/xfa/fwl/cfwl_themetext.h b/xfa/fwl/cfwl_themetext.h
index a0e9f31..aa164f7 100644
--- a/xfa/fwl/cfwl_themetext.h
+++ b/xfa/fwl/cfwl_themetext.h
@@ -7,6 +7,7 @@
 #ifndef XFA_FWL_CFWL_THEMETEXT_H_
 #define XFA_FWL_CFWL_THEMETEXT_H_
 
+#include "core/fxcrt/fx_memory.h"
 #include "core/fxcrt/unowned_ptr.h"
 #include "core/fxcrt/widestring.h"
 #include "xfa/fde/cfde_data.h"
@@ -16,6 +17,8 @@
 
 class CFWL_ThemeText final : public CFWL_ThemePart {
  public:
+  FX_STACK_ALLOCATED();
+
   CFWL_ThemeText(CFWL_Widget* pWidget, CFGAS_GEGraphics* pGraphics);
   ~CFWL_ThemeText();