commit 435a508730a6509af8fd1f3ab44e70f5a450f9e0
author Tom Sepez <tsepez@chromium.org> Wed Aug 31 23:30:28 2022 +0000
committer Pdfium LUCI CQ <pdfium-scoped@luci-project-accounts.iam.gserviceaccount.com> Wed Aug 31 23:30:28 2022 +0000
tree d85cafbf3073af798f0d084143eed14605bf05b1
parent 3ea81de1d93cd27d4fcb8f6a9ed13f95dbfa4605

Remove unused non-const form of CPDF_Object::SafeGetDirect()

Only the const form is actually needed.

Change-Id: Ic03dc719f3bc91016052d22971b3ab8bbc8989cb
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/97271
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Tom Sepez <tsepez@chromium.org>

core/fpdfapi/parser/cpdf_reference.cpp

diff --git a/core/fpdfapi/parser/cpdf_reference.cpp b/core/fpdfapi/parser/cpdf_reference.cpp
index 814c89e..ef37f14 100644
--- a/core/fpdfapi/parser/cpdf_reference.cpp
+++ b/core/fpdfapi/parser/cpdf_reference.cpp
@@ -69,11 +69,6 @@
   return pdfium::MakeRetain<CPDF_Reference>(m_pObjList.Get(), m_RefObjNum);
 }
 
-CPDF_Object* CPDF_Reference::SafeGetDirect() {
-  RetainPtr<CPDF_Object> obj = GetMutableDirect();
-  return (obj && !obj->IsReference()) ? obj.Get() : nullptr;
-}
-
 const CPDF_Object* CPDF_Reference::SafeGetDirect() const {
   const CPDF_Object* obj = GetDirect();
   return (obj && !obj->IsReference()) ? obj : nullptr;

core/fpdfapi/parser/cpdf_reference.h

diff --git a/core/fpdfapi/parser/cpdf_reference.h b/core/fpdfapi/parser/cpdf_reference.h
index b468442..fd3249c 100644
--- a/core/fpdfapi/parser/cpdf_reference.h
+++ b/core/fpdfapi/parser/cpdf_reference.h
@@ -45,7 +45,6 @@
   RetainPtr<CPDF_Object> CloneNonCyclic(
       bool bDirect,
       std::set<const CPDF_Object*>* pVisited) const override;
-  CPDF_Object* SafeGetDirect();
   const CPDF_Object* SafeGetDirect() const;
 
   UnownedPtr<CPDF_IndirectObjectHolder> m_pObjList;