commit | 7b8416e7991c5919002f6b9be06b64a180e745f9 | [log] [tgz] |
---|---|---|
author | Tom Sepez <tsepez@chromium.org> | Sat Nov 05 00:33:25 2022 +0000 |
committer | Pdfium LUCI CQ <pdfium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Sat Nov 05 00:33:25 2022 +0000 |
tree | e5a12424c3ea0ce5888a4bb33086aa7aceaee93f | |
parent | 490d681305e62e5358eb3bd4d49951f9394673ff [diff] |
Add NOLINTNEXTLINE missed in prior CL. Should have been part of https://pdfium-review.googlesource.com/c/pdfium/+/100680 Change-Id: I4ba03ec2e3bb9ead64facc0745fe446422b4562c Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/100682 Commit-Queue: Lei Zhang <thestig@chromium.org> Auto-Submit: Tom Sepez <tsepez@chromium.org> Commit-Queue: Tom Sepez <tsepez@chromium.org> Reviewed-by: Lei Zhang <thestig@chromium.org>
diff --git a/fpdfsdk/fpdf_structtree.cpp b/fpdfsdk/fpdf_structtree.cpp index b0029cc..76a30be 100644 --- a/fpdfsdk/fpdf_structtree.cpp +++ b/fpdfsdk/fpdf_structtree.cpp
@@ -163,9 +163,10 @@ const CPDF_Array* array = attr_obj->AsArray(); if (index < 0 || static_cast<size_t>(index) >= array->size()) return nullptr; + // TODO(tsepez): should embedder take a reference here? - return FPDFStructElementAttrFromCPDFDictionary( - array->GetDictAt(index).Get()); + // Unretained reference in public API. NOLINTNEXTLINE + return FPDFStructElementAttrFromCPDFDictionary(array->GetDictAt(index)); } return nullptr; }