commit 168173ce12c6183f23941597b2079403163d4d9c
author K. Moon <kmoon@chromium.org> Fri Mar 03 22:33:29 2023 +0000
committer Pdfium LUCI CQ <pdfium-scoped@luci-project-accounts.iam.gserviceaccount.com> Fri Mar 03 22:33:29 2023 +0000
tree bc7d2e02c1e6477f8d77c502d305288153f32c4c
parent f5756d30d493aa9e28a9b3452303351fb6d9763a

Enable xfermodes{2,3}.pdf tests for Skia

Unsuppresses the xfermodes2.pdf and xfermodes3.pdf corpus tests for
Skia, as they now render correctly. Due to device-specific differences
for ColorBurn blending (pdfium:1991), these tests use fuzzy matching.

Note that the Skia result for xfermodes2.pdf is now the default
expectation, as it matches Acrobat better than AGG does. In particular,
AGG renders ColorDodge with too much red, and ColorBurn with too little
green. AGG is now suppressed instead (pdfium:1990).

Bug: pdfium:1990
Fixed: pdfium:1959
Change-Id: If80665a850777b0243737c54e5501e2697f77688
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/103954
Commit-Queue: K. Moon <kmoon@chromium.org>
Reviewed-by: Nigi <nigi@chromium.org>

DEPS

diff --git a/DEPS b/DEPS
index 0a6f37e..54e2edd 100644
--- a/DEPS
+++ b/DEPS
@@ -140,7 +140,7 @@
   # Three lines of non-changing comments so that
   # the commit queue can handle CLs rolling pdfium_tests
   # and whatever else without interference from each other.
-  'pdfium_tests_revision': '897769bc058701ae38eb12285703e6c8d3ba1aee',
+  'pdfium_tests_revision': '5275dbcb7cfa4b6b7e049d7a4e2b58a86fa3aca0',
   # Three lines of non-changing comments so that
   # the commit queue can handle CLs rolling resultdb
   # and whatever else without interference from each other.

testing/SUPPRESSIONS

diff --git a/testing/SUPPRESSIONS b/testing/SUPPRESSIONS
index e07b453..b05b633 100644
--- a/testing/SUPPRESSIONS
+++ b/testing/SUPPRESSIONS
@@ -293,11 +293,8 @@
 whats_new_in_v3.0.pdf mac * * *
 widget_javascript.pdf mac * * *
 
-# TODO(pdfium:1959): Remove after associated bug is fixed
-xfermodes2.pdf * * * skia
-
-# TODO(pdfium:1959): Remove after associated bug is fixed
-xfermodes3.pdf * * * skia
+# TODO(pdfium:1990): Remove after associated bug is fixed
+xfermodes2.pdf * * * agg
 
 zh_file1.pdf mac * * *
 zh_function_list.pdf mac * * *

testing/SUPPRESSIONS_EXACT_MATCHING

diff --git a/testing/SUPPRESSIONS_EXACT_MATCHING b/testing/SUPPRESSIONS_EXACT_MATCHING
index 374549d..7c260d1 100644
--- a/testing/SUPPRESSIONS_EXACT_MATCHING
+++ b/testing/SUPPRESSIONS_EXACT_MATCHING
@@ -18,3 +18,11 @@
 # The filenames and keywords are case-sensitive.
 #
 # Try to keep the file alphabetized within each category of test.
+
+#
+# Corpus tests
+#
+
+# Device-specific ColorBurn differences (see pdfium:1959).
+xfermodes2.pdf * * * skia
+xfermodes3.pdf * * * skia