commit 15b1203da8e9be060d143a184de6473ca7a68b83
author Lei Zhang <thestig@chromium.org> Tue Mar 21 02:13:38 2023 +0000
committer Pdfium LUCI CQ <pdfium-scoped@luci-project-accounts.iam.gserviceaccount.com> Tue Mar 21 02:13:38 2023 +0000
tree 394bbb05e590e7db5438689fb3da7d577ee14c56
parent 99dbaf4f6011a8a4e696720bec04e14d0adcd78d

Use NOTREACHED_NORETURN() in fpdfsdk

Test the waters and see if NOTREACHED() is truly not reached.

Bug: pdfium:2008
Change-Id: I1b4f7d3f050f467c3138dbfaf48b98f8111efebe
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/105150
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>

fpdfsdk/cpdfsdk_formfillenvironment.cpp

diff --git a/fpdfsdk/cpdfsdk_formfillenvironment.cpp b/fpdfsdk/cpdfsdk_formfillenvironment.cpp
index c2c9650d..84df6e1 100644
--- a/fpdfsdk/cpdfsdk_formfillenvironment.cpp
+++ b/fpdfsdk/cpdfsdk_formfillenvironment.cpp
@@ -1039,7 +1039,7 @@
       DoActionResetForm(action);
       break;
     case CPDF_Action::Type::kJavaScript:
-      NOTREACHED();
+      NOTREACHED_NORETURN();
       break;
     case CPDF_Action::Type::kSetOCGState:
     case CPDF_Action::Type::kThread:
@@ -1122,7 +1122,7 @@
                                   pFormField, &data->sValue, &data->bRC);
         break;
       default:
-        NOTREACHED();
+        NOTREACHED_NORETURN();
         break;
     }
   });
@@ -1169,7 +1169,7 @@
         context->OnPage_OutView();
         break;
       default:
-        NOTREACHED();
+        NOTREACHED_NORETURN();
         break;
     }
   });

fpdfsdk/cpdfsdk_widget.cpp

diff --git a/fpdfsdk/cpdfsdk_widget.cpp b/fpdfsdk/cpdfsdk_widget.cpp
index 4cf176f..c336f5e 100644
--- a/fpdfsdk/cpdfsdk_widget.cpp
+++ b/fpdfsdk/cpdfsdk_widget.cpp
@@ -176,7 +176,7 @@
       break;
     case CPDF_AAction::kDocumentOpen:
     case CPDF_AAction::kNumberOfActions:
-      NOTREACHED();
+      NOTREACHED_NORETURN();
       break;
   }
 

fpdfsdk/fpdf_flatten.cpp

diff --git a/fpdfsdk/fpdf_flatten.cpp b/fpdfsdk/fpdf_flatten.cpp
index ac5b6fc..4eb8ebe 100644
--- a/fpdfsdk/fpdf_flatten.cpp
+++ b/fpdfsdk/fpdf_flatten.cpp
@@ -150,7 +150,7 @@
         pArray[i] = array[i].bottom;
       break;
     default:
-      NOTREACHED();
+      NOTREACHED_NORETURN();
       return 0.0f;
   }
 

fpdfsdk/pwl/cpwl_cblistbox.cpp

diff --git a/fpdfsdk/pwl/cpwl_cblistbox.cpp b/fpdfsdk/pwl/cpwl_cblistbox.cpp
index 9a418a3..492b6ae 100644
--- a/fpdfsdk/pwl/cpwl_cblistbox.cpp
+++ b/fpdfsdk/pwl/cpwl_cblistbox.cpp
@@ -74,7 +74,7 @@
       m_pListCtrl->OnVK_RIGHT(IsSHIFTKeyDown(nFlag), IsCTRLKeyDown(nFlag));
       break;
     default:
-      NOTREACHED();
+      NOTREACHED_NORETURN();
       break;
   }
   return OnNotifySelectionChanged(true, nFlag);