commit cffe2384b839649d29283e8f56b8a40f993bd2cd
author Lei Zhang <thestig@chromium.org> Tue Apr 18 00:44:02 2023 +0000
committer Pdfium LUCI CQ <pdfium-scoped@luci-project-accounts.iam.gserviceaccount.com> Tue Apr 18 00:44:02 2023 +0000
tree 822dbb763fb7e74001709f8620abc35ce546bab1
parent 2327115fdafadfb7db6952796aa08a9897437afc

Remove a spurious RetainPtr in the CFX_DIBExtractor ctor

The extra refcount is not necessary.

Change-Id: Id97a7e01018d4f25e7e8ccbe20b95ef35854de1b
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/106210
Commit-Queue: Lei Zhang <thestig@chromium.org>
Reviewed-by: Nigi <nigi@chromium.org>

core/fxge/dib/cfx_dibextractor.cpp

diff --git a/core/fxge/dib/cfx_dibextractor.cpp b/core/fxge/dib/cfx_dibextractor.cpp
index 1d2d920..9dcfbec 100644
--- a/core/fxge/dib/cfx_dibextractor.cpp
+++ b/core/fxge/dib/cfx_dibextractor.cpp
@@ -14,15 +14,15 @@
     m_pBitmap = pSrc->Realize();
     return;
   }
-  RetainPtr<CFX_DIBBase> pOldSrc(pSrc);
   m_pBitmap = pdfium::MakeRetain<CFX_DIBitmap>();
-  if (!m_pBitmap->Create(pOldSrc->GetWidth(), pOldSrc->GetHeight(),
-                         pOldSrc->GetFormat(), pOldSrc->GetBuffer().data(),
-                         0)) {
+  if (!m_pBitmap->Create(pSrc->GetWidth(), pSrc->GetHeight(), pSrc->GetFormat(),
+                         pSrc->GetBuffer().data(),
+                         /*pitch=*/0)) {
     m_pBitmap.Reset();
     return;
   }
-  m_pBitmap->SetPalette(pOldSrc->GetPaletteSpan());
+
+  m_pBitmap->SetPalette(pSrc->GetPaletteSpan());
 }
 
 CFX_DIBExtractor::~CFX_DIBExtractor() = default;