No need to depend on all of base in chromium build.
Now that partition alloc is fully stand-alone, and that the visibility
constraint has been removed in
https://chromium-review.googlesource.com/c/chromium/src/+/4714471
PDFium can always use a narrower set of deps in its build files.
Change-Id: Ibe99a9d44f64db825bd88cc82438113009096266
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/110270
Reviewed-by: K. Moon <kmoon@chromium.org>
Commit-Queue: Tom Sepez <tsepez@chromium.org>
diff --git a/core/fxcrt/BUILD.gn b/core/fxcrt/BUILD.gn
index 272dd22..e72220b 100644
--- a/core/fxcrt/BUILD.gn
+++ b/core/fxcrt/BUILD.gn
@@ -11,14 +11,10 @@
deps = [ "../../third_party:pdfium_compiler_specific" ]
configs += [ "../../:pdfium_strict_config" ]
if (pdf_use_partition_alloc) {
- if (build_with_chromium) {
- deps += [ "//base" ]
- } else {
- deps += [
- "//base/allocator/partition_allocator:partition_alloc_buildflags",
- "//base/allocator/partition_allocator:raw_ptr",
- ]
- }
+ deps += [
+ "//base/allocator/partition_allocator:partition_alloc_buildflags",
+ "//base/allocator/partition_allocator:raw_ptr",
+ ]
}
}
@@ -146,15 +142,11 @@
]
if (pdf_use_partition_alloc) {
sources += [ "fx_memory_pa.cpp" ]
- if (build_with_chromium) {
- deps += [ "//base" ]
- } else {
- deps += [
- "//base/allocator/partition_allocator:partition_alloc",
- "//base/allocator/partition_allocator:partition_alloc_buildflags",
- "//base/allocator/partition_allocator:raw_ptr",
- ]
- }
+ deps += [
+ "//base/allocator/partition_allocator:partition_alloc",
+ "//base/allocator/partition_allocator:partition_alloc_buildflags",
+ "//base/allocator/partition_allocator:raw_ptr",
+ ]
} else {
sources += [ "fx_memory_malloc.cpp" ]
}