Avoid potential msan warnings in test SpanEquals.Empty
Route the comparison through FXSYS_memcmp() instead of system memcmp(),
since the former tolerates nullptrs.
Change-Id: Id0a01a19b64ee47e6bb64c81c53dbe51f68e6309
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/116230
Commit-Queue: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Thomas Sepez <tsepez@google.com>
Reviewed-by: Lei Zhang <thestig@chromium.org>
diff --git a/core/fxcrt/span_util.h b/core/fxcrt/span_util.h
index a5834aa..99ae5de 100644
--- a/core/fxcrt/span_util.h
+++ b/core/fxcrt/span_util.h
@@ -66,7 +66,7 @@
std::is_trivially_copyable_v<U>>>
bool span_equals(pdfium::span<T> s1, pdfium::span<U> s2) {
return s1.size_bytes() == s2.size_bytes() &&
- memcmp(s1.data(), s2.data(), s1.size_bytes()) == 0;
+ FXSYS_memcmp(s1.data(), s2.data(), s1.size_bytes()) == 0;
}
template <typename T,
