commit 054fc955c153eb5c581fd14946848b8b2a77136a
author Jun Fang <jun_fang@foxitsoftware.com> Fri Jan 01 00:16:13 2016 +0800
committer Jun Fang <jun_fang@foxitsoftware.com> Fri Jan 01 00:16:13 2016 +0800
tree 27113413aeed27d481236e645b1abb58c969b7f0
parent 8f6f036678515a203051bb83c975472ed26b3203

Revert "Fix a partial rendering problem"

This reverts commit 84f6a5616be0a1988d361a4b54eb83fff8b8c59f.

BUG=pdfium:336
TBR=thestig@chromium.org

Review URL: https://codereview.chromium.org/1554883002 .

samples/pdfium_test.cc

diff --git a/samples/pdfium_test.cc b/samples/pdfium_test.cc
index 89430f6..1b3d826 100644
--- a/samples/pdfium_test.cc
+++ b/samples/pdfium_test.cc
@@ -15,7 +15,6 @@
 
 #include "image_diff_png.h"
 #include "public/fpdf_dataavail.h"
-#include "public/fpdf_edit.h"
 #include "public/fpdf_ext.h"
 #include "public/fpdf_formfill.h"
 #include "public/fpdf_text.h"
@@ -351,14 +350,14 @@
   }
   int width = static_cast<int>(FPDF_GetPageWidth(page) * scale);
   int height = static_cast<int>(FPDF_GetPageHeight(page) * scale);
-  int alpha = FPDFPage_HasTransparency(page) ? 1 : 0;
-  FPDF_BITMAP bitmap = FPDFBitmap_Create(width, height, alpha);
+
+  FPDF_BITMAP bitmap = FPDFBitmap_Create(width, height, 0);
   if (!bitmap) {
     fprintf(stderr, "Page was too large to be rendered.\n");
     return false;
   }
-  FPDF_DWORD fill_color = alpha ? 0x00000000 : 0xFFFFFFFF;
-  FPDFBitmap_FillRect(bitmap, 0, 0, width, height, fill_color);
+
+  FPDFBitmap_FillRect(bitmap, 0, 0, width, height, 0xFFFFFFFF);
   FPDF_RenderPageBitmap(bitmap, page, 0, 0, width, height, 0, 0);
 
   FPDF_FFLDraw(form, bitmap, page, 0, 0, width, height, 0, 0);

testing/embedder_test.cpp

diff --git a/testing/embedder_test.cpp b/testing/embedder_test.cpp
index 33c7220..d4ce7eb 100644
--- a/testing/embedder_test.cpp
+++ b/testing/embedder_test.cpp
@@ -12,7 +12,6 @@
 #include <vector>
 
 #include "public/fpdf_dataavail.h"
-#include "public/fpdf_edit.h"
 #include "public/fpdf_text.h"
 #include "public/fpdfview.h"
 #include "testing/gmock/include/gmock/gmock.h"
@@ -214,10 +213,8 @@
 FPDF_BITMAP EmbedderTest::RenderPage(FPDF_PAGE page) {
   int width = static_cast<int>(FPDF_GetPageWidth(page));
   int height = static_cast<int>(FPDF_GetPageHeight(page));
-  int alpha = FPDFPage_HasTransparency(page) ? 1 : 0;
-  FPDF_BITMAP bitmap = FPDFBitmap_Create(width, height, alpha);
-  FPDF_DWORD fill_color = alpha ? 0x00000000 : 0xFFFFFFFF;
-  FPDFBitmap_FillRect(bitmap, 0, 0, width, height, fill_color);
+  FPDF_BITMAP bitmap = FPDFBitmap_Create(width, height, 0);
+  FPDFBitmap_FillRect(bitmap, 0, 0, width, height, 0xFFFFFFFF);
   FPDF_RenderPageBitmap(bitmap, page, 0, 0, width, height, 0, 0);
   FPDF_FFLDraw(form_handle_, bitmap, page, 0, 0, width, height, 0, 0);
   return bitmap;