Remove unneeded logging.h includes. Remove includes from files that do not need them. Then do IWYU for those that do. Change-Id: I941fb4afc3896719461fee354c0c42e25fdbb11a Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/74290 Reviewed-by: Tom Sepez <tsepez@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org>
diff --git a/core/fpdfapi/font/cpdf_cmapparser.cpp b/core/fpdfapi/font/cpdf_cmapparser.cpp index 236d429..2e25669 100644 --- a/core/fpdfapi/font/cpdf_cmapparser.cpp +++ b/core/fpdfapi/font/cpdf_cmapparser.cpp
@@ -13,7 +13,6 @@ #include "core/fxcrt/fx_extension.h" #include "core/fxcrt/fx_safe_types.h" #include "core/fxge/fx_freetype.h" -#include "third_party/base/logging.h" #include "third_party/base/stl_util.h" namespace {
diff --git a/core/fpdfapi/font/cpdf_font.cpp b/core/fpdfapi/font/cpdf_font.cpp index 80a3f4a..edb37e9 100644 --- a/core/fpdfapi/font/cpdf_font.cpp +++ b/core/fpdfapi/font/cpdf_font.cpp
@@ -29,7 +29,6 @@ #include "core/fxge/cfx_fontmapper.h" #include "core/fxge/fx_font.h" #include "core/fxge/fx_freetype.h" -#include "third_party/base/logging.h" #include "third_party/base/stl_util.h" namespace {
diff --git a/core/fxcodec/bmp/cfx_bmpdecompressor.cpp b/core/fxcodec/bmp/cfx_bmpdecompressor.cpp index 21e991a..2f5038d 100644 --- a/core/fxcodec/bmp/cfx_bmpdecompressor.cpp +++ b/core/fxcodec/bmp/cfx_bmpdecompressor.cpp
@@ -16,7 +16,6 @@ #include "core/fxcrt/fx_memory_wrappers.h" #include "core/fxcrt/fx_safe_types.h" #include "core/fxcrt/fx_system.h" -#include "third_party/base/logging.h" #include "third_party/base/numerics/safe_math.h" namespace fxcodec {
diff --git a/core/fxcodec/fax/faxmodule.cpp b/core/fxcodec/fax/faxmodule.cpp index 6bb89be..8b62dc6 100644 --- a/core/fxcodec/fax/faxmodule.cpp +++ b/core/fxcodec/fax/faxmodule.cpp
@@ -16,7 +16,6 @@ #include "core/fxcodec/scanlinedecoder.h" #include "core/fxcrt/cfx_binarybuf.h" #include "core/fxcrt/fx_memory_wrappers.h" -#include "third_party/base/logging.h" #include "third_party/base/stl_util.h" namespace fxcodec {
diff --git a/core/fxcodec/jpeg/jpeg_progressive_decoder.cpp b/core/fxcodec/jpeg/jpeg_progressive_decoder.cpp index 80bbe18..e5a293c 100644 --- a/core/fxcodec/jpeg/jpeg_progressive_decoder.cpp +++ b/core/fxcodec/jpeg/jpeg_progressive_decoder.cpp
@@ -16,7 +16,6 @@ #include "core/fxcrt/fx_safe_types.h" #include "core/fxge/dib/cfx_dibbase.h" #include "core/fxge/fx_dib.h" -#include "third_party/base/logging.h" #include "third_party/base/optional.h" #include "third_party/base/ptr_util.h"
diff --git a/core/fxcrt/retained_tree_node.h b/core/fxcrt/retained_tree_node.h index a859ae5..3c550d9 100644 --- a/core/fxcrt/retained_tree_node.h +++ b/core/fxcrt/retained_tree_node.h
@@ -7,7 +7,6 @@ #include "core/fxcrt/retain_ptr.h" #include "core/fxcrt/tree_node.h" -#include "third_party/base/logging.h" namespace fxcrt {
diff --git a/samples/pdfium_test.cc b/samples/pdfium_test.cc index d390169..ee7b41c 100644 --- a/samples/pdfium_test.cc +++ b/samples/pdfium_test.cc
@@ -40,7 +40,6 @@ #include "testing/utils/file_util.h" #include "testing/utils/hash.h" #include "testing/utils/path_service.h" -#include "third_party/base/logging.h" #include "third_party/base/optional.h" #ifdef _WIN32
diff --git a/testing/fuzzers/pdf_formcalc_fuzzer.cc b/testing/fuzzers/pdf_formcalc_fuzzer.cc index 89b9122..b43b606 100644 --- a/testing/fuzzers/pdf_formcalc_fuzzer.cc +++ b/testing/fuzzers/pdf_formcalc_fuzzer.cc
@@ -6,7 +6,6 @@ #include "core/fxcrt/fx_string.h" #include "testing/fuzzers/pdfium_fuzzer_util.h" #include "testing/fuzzers/xfa_process_state.h" -#include "third_party/base/logging.h" #include "xfa/fxfa/fm2js/cxfa_fmparser.h" extern "C" int LLVMFuzzerTestOneInput(const uint8_t* data, size_t size) {
diff --git a/testing/image_diff/image_diff.cpp b/testing/image_diff/image_diff.cpp index c8f9caf..5bfef4c 100644 --- a/testing/image_diff/image_diff.cpp +++ b/testing/image_diff/image_diff.cpp
@@ -21,7 +21,6 @@ #include "core/fxcrt/fx_memory.h" #include "testing/image_diff/image_diff_png.h" #include "testing/utils/path_service.h" -#include "third_party/base/logging.h" #include "third_party/base/numerics/safe_conversions.h" #if defined(OS_WIN)
diff --git a/third_party/base/allocator/partition_allocator/partition_alloc_constants.h b/third_party/base/allocator/partition_allocator/partition_alloc_constants.h index 71d63ba..e3bcf5a 100644 --- a/third_party/base/allocator/partition_allocator/partition_alloc_constants.h +++ b/third_party/base/allocator/partition_allocator/partition_alloc_constants.h
@@ -10,7 +10,6 @@ #include "build/build_config.h" #include "third_party/base/allocator/partition_allocator/page_allocator_constants.h" -#include "third_party/base/logging.h" #if defined(OS_APPLE) #include <mach/vm_page_size.h>
diff --git a/third_party/base/allocator/partition_allocator/partition_bucket.h b/third_party/base/allocator/partition_allocator/partition_bucket.h index f70a7da..8bcddb7 100644 --- a/third_party/base/allocator/partition_allocator/partition_bucket.h +++ b/third_party/base/allocator/partition_allocator/partition_bucket.h
@@ -10,6 +10,7 @@ #include "third_party/base/allocator/partition_allocator/partition_alloc_constants.h" #include "third_party/base/base_export.h" +#include "third_party/base/check.h" #include "third_party/base/compiler_specific.h" namespace pdfium {
diff --git a/xfa/fxfa/fm2js/cxfa_fmexpression.cpp b/xfa/fxfa/fm2js/cxfa_fmexpression.cpp index 442fef9..38e58e9 100644 --- a/xfa/fxfa/fm2js/cxfa_fmexpression.cpp +++ b/xfa/fxfa/fm2js/cxfa_fmexpression.cpp
@@ -13,7 +13,6 @@ #include "core/fxcrt/cfx_widetextbuf.h" #include "core/fxcrt/fx_extension.h" #include "fxjs/gc/container_trace.h" -#include "third_party/base/logging.h" #include "v8/include/cppgc/visitor.h" #include "xfa/fxfa/fm2js/cxfa_fmtojavascriptdepth.h"
diff --git a/xfa/fxfa/layout/cxfa_contentlayoutitem.cpp b/xfa/fxfa/layout/cxfa_contentlayoutitem.cpp index ac850dd..39f9035 100644 --- a/xfa/fxfa/layout/cxfa_contentlayoutitem.cpp +++ b/xfa/fxfa/layout/cxfa_contentlayoutitem.cpp
@@ -7,6 +7,7 @@ #include "xfa/fxfa/layout/cxfa_contentlayoutitem.h" #include "fxjs/xfa/cjx_object.h" +#include "third_party/base/logging.h" #include "xfa/fxfa/cxfa_ffwidget.h" #include "xfa/fxfa/parser/cxfa_margin.h" #include "xfa/fxfa/parser/cxfa_node.h"