Remove parameter to CPDFSDK_Widget::ResetFieldAppearance(). All the callers pass in the same argument. Change-Id: Id09e0f2c54f8aed8bf85c3cb79f2b79983e0541c Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/58330 Reviewed-by: Tom Sepez <tsepez@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org>
diff --git a/fpdfsdk/cpdfsdk_widget.cpp b/fpdfsdk/cpdfsdk_widget.cpp index 8a6f3c2..35db23f 100644 --- a/fpdfsdk/cpdfsdk_widget.cpp +++ b/fpdfsdk/cpdfsdk_widget.cpp
@@ -638,11 +638,10 @@ return m_pInteractiveForm->OnFormat(pFormField); } -void CPDFSDK_Widget::ResetFieldAppearance(bool bValueChanged) { +void CPDFSDK_Widget::ResetFieldAppearance() { CPDF_FormField* pFormField = GetFormField(); ASSERT(pFormField); - m_pInteractiveForm->ResetFieldAppearance(pFormField, pdfium::nullopt, - bValueChanged); + m_pInteractiveForm->ResetFieldAppearance(pFormField, pdfium::nullopt, true); } void CPDFSDK_Widget::DrawAppearance(CFX_RenderDevice* pDevice,
diff --git a/fpdfsdk/cpdfsdk_widget.h b/fpdfsdk/cpdfsdk_widget.h index 81d0a4c..7953b5e 100644 --- a/fpdfsdk/cpdfsdk_widget.h +++ b/fpdfsdk/cpdfsdk_widget.h
@@ -90,7 +90,7 @@ void ResetAppearance(bool bValueChanged); #endif // PDF_ENABLE_XFA void ResetAppearance(Optional<WideString> sValue, bool bValueChanged); - void ResetFieldAppearance(bool bValueChanged); + void ResetFieldAppearance(); void UpdateField(); Optional<WideString> OnFormat();
diff --git a/fpdfsdk/formfiller/cffl_combobox.cpp b/fpdfsdk/formfiller/cffl_combobox.cpp index 7cce34d..0a638f7 100644 --- a/fpdfsdk/formfiller/cffl_combobox.cpp +++ b/fpdfsdk/formfiller/cffl_combobox.cpp
@@ -112,7 +112,7 @@ } ObservedPtr<CPDFSDK_Widget> observed_widget(m_pWidget.Get()); ObservedPtr<CFFL_ComboBox> observed_this(this); - m_pWidget->ResetFieldAppearance(true); + m_pWidget->ResetFieldAppearance(); if (!observed_widget) return;
diff --git a/fpdfsdk/formfiller/cffl_listbox.cpp b/fpdfsdk/formfiller/cffl_listbox.cpp index a90cac6..37e2046 100644 --- a/fpdfsdk/formfiller/cffl_listbox.cpp +++ b/fpdfsdk/formfiller/cffl_listbox.cpp
@@ -129,7 +129,7 @@ if (!observed_widget) return; - m_pWidget->ResetFieldAppearance(true); + m_pWidget->ResetFieldAppearance(); if (!observed_widget) return;
diff --git a/fpdfsdk/formfiller/cffl_textfield.cpp b/fpdfsdk/formfiller/cffl_textfield.cpp index a0c60b8..bdde87e 100644 --- a/fpdfsdk/formfiller/cffl_textfield.cpp +++ b/fpdfsdk/formfiller/cffl_textfield.cpp
@@ -147,7 +147,7 @@ if (!observed_widget) return; - m_pWidget->ResetFieldAppearance(true); + m_pWidget->ResetFieldAppearance(); if (!observed_widget) return;