De-virtualize CBC_OneDimWriter::RenderTextContents(). It is only ever called in cbc_code39.cpp directly on the one subclass that actually implements it. Change-Id: I462251c2ee564ad1ee47390a3496e08b1385b261 Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/62050 Reviewed-by: Lei Zhang <thestig@chromium.org> Commit-Queue: Tom Sepez <tsepez@chromium.org>
diff --git a/fxbarcode/oned/BC_OneDimWriter.cpp b/fxbarcode/oned/BC_OneDimWriter.cpp index 7cd06ec..5a02cdf 100644 --- a/fxbarcode/oned/BC_OneDimWriter.cpp +++ b/fxbarcode/oned/BC_OneDimWriter.cpp
@@ -303,7 +303,3 @@ m_output.back().AppendRect(x, 0.0f, x + 1, 1.0f); } } - -WideString CBC_OneDimWriter::RenderTextContents(WideStringView contents) { - return WideString(); -}
diff --git a/fxbarcode/oned/BC_OneDimWriter.h b/fxbarcode/oned/BC_OneDimWriter.h index 9a28479..3e0ccc9 100644 --- a/fxbarcode/oned/BC_OneDimWriter.h +++ b/fxbarcode/oned/BC_OneDimWriter.h
@@ -30,7 +30,6 @@ int32_t codeLength); virtual bool CheckContentValidity(WideStringView contents) = 0; virtual WideString FilterContents(WideStringView contents) = 0; - virtual WideString RenderTextContents(WideStringView contents); virtual void SetPrintChecksum(bool checksum); virtual void SetDataLength(int32_t length); virtual void SetCalcChecksum(bool state);
diff --git a/fxbarcode/oned/BC_OnedCode39Writer.h b/fxbarcode/oned/BC_OnedCode39Writer.h index 945099c..525573a 100644 --- a/fxbarcode/oned/BC_OnedCode39Writer.h +++ b/fxbarcode/oned/BC_OnedCode39Writer.h
@@ -27,10 +27,10 @@ int32_t codeLength) override; bool CheckContentValidity(WideStringView contents) override; WideString FilterContents(WideStringView contents) override; - WideString RenderTextContents(WideStringView contents) override; bool SetTextLocation(BC_TEXT_LOC location) override; bool SetWideNarrowRatio(int8_t ratio) override; + WideString RenderTextContents(WideStringView contents); bool encodedContents(WideStringView contents, WideString* result); private: