Reduce no_chromium_code build config usage.

Various build targets, including some in third_party/, are really first
party code in the sense that they are written by PDFium or Chromium
authors. As such, the code quality for those targets is high enough that
they can be use the "chromium_code" build config, which enables more
warnings.

Change-Id: If73f5bd4217be2f8656e2da664b59b85d7d1aa09
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/79852
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>

BUILD.gn

diff --git a/BUILD.gn b/BUILD.gn
index 18f6ce9..5acd071 100644
--- a/BUILD.gn
+++ b/BUILD.gn
@@ -354,8 +354,6 @@
     "testing/image_diff",
     "//build/win:default_exe_manifest",
   ]
-  configs -= [ "//build/config/compiler:chromium_code" ]
-  configs += [ "//build/config/compiler:no_chromium_code" ]
   configs += [ ":pdfium_core_config" ]
 }
 

testing/fuzzers/BUILD.gn

diff --git a/testing/fuzzers/BUILD.gn b/testing/fuzzers/BUILD.gn
index b6f7c77..5b2e337 100644
--- a/testing/fuzzers/BUILD.gn
+++ b/testing/fuzzers/BUILD.gn
@@ -197,11 +197,7 @@
     if (defined(invoker.deps)) {
       deps += invoker.deps
     }
-    configs -= [ "//build/config/compiler:chromium_code" ]
-    configs += [
-      "//build/config/compiler:no_chromium_code",
-      ":fuzzer_config",
-    ]
+    configs += [ ":fuzzer_config" ]
     if (is_component_build) {
       # |export| should be consistent with FPDF_EXPORT In public/fpdfview.h.
       if (is_win) {

third_party/BUILD.gn

diff --git a/third_party/BUILD.gn b/third_party/BUILD.gn
index 2e1ed11..a8b8835 100644
--- a/third_party/BUILD.gn
+++ b/third_party/BUILD.gn
@@ -638,11 +638,7 @@
 
 source_set("pdfium_base_test_support") {
   testonly = true
-  configs -= [ "//build/config/compiler:chromium_code" ]
-  configs += [
-    "//build/config/compiler:no_chromium_code",
-    ":pdfium_third_party_config",
-  ]
+  configs += [ "../:pdfium_core_config" ]
   sources = []
   deps = []
 
@@ -656,11 +652,7 @@
 }
 
 source_set("skia_shared") {
-  configs -= [ "//build/config/compiler:chromium_code" ]
-  configs += [
-    "//build/config/compiler:no_chromium_code",
-    ":pdfium_third_party_config",
-  ]
+  configs += [ "../:pdfium_core_config" ]
   sources = [
     "skia_shared/SkFloatToDecimal.cpp",
     "skia_shared/SkFloatToDecimal.h",