commit 8b5dfb2104c69c7dc3f3a015b8d32829d1f0015f
author Hui Yingst <nigi@chromium.org> Tue Jul 21 17:08:30 2020 +0000
committer Chromium commit bot <commit-bot@chromium.org> Tue Jul 21 17:08:30 2020 +0000
tree f90b4eb79deda1eeaa580cbead939c3d22252f6c
parent ce2ad6c94bff1897c355b5480fe6fe4f58678b78

Enable FPDFEditEmbedderTest.InsertAndRemoveLargeFile for Skia/SkiaPaths.

For FPDFEditEmbedderTest.InsertAndRemoveLargeFile, Skia/SkiaPaths
rendering results have discrepancies compared to AGG due to using
different algorithms for rendering gradient transition and subpixels,
but the discrepancies are acceptable (See rendering results:
https://crbug.com/pdfium/1500#c24).

Therefore, this CL adds the expected results for Skia/SkiaPaths to
make the embedder test pass.

Bug: pdfium:1500
Change-Id: I05813004626d742830b2d1a0338a0b6e85334c3f
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/70632
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Hui Yingst <nigi@chromium.org>

fpdfsdk/fpdf_edit_embeddertest.cpp

diff --git a/fpdfsdk/fpdf_edit_embeddertest.cpp b/fpdfsdk/fpdf_edit_embeddertest.cpp
index 6371efc..dbf71e9 100644
--- a/fpdfsdk/fpdf_edit_embeddertest.cpp
+++ b/fpdfsdk/fpdf_edit_embeddertest.cpp
@@ -1705,13 +1705,7 @@
   CloseSavedDocument();
 }
 
-// TODO(crbug.com/pdfium/11): Fix this test and enable.
-#if defined(_SKIA_SUPPORT_) || defined(_SKIA_SUPPORT_PATHS_)
-#define MAYBE_InsertAndRemoveLargeFile DISABLED_InsertAndRemoveLargeFile
-#else
-#define MAYBE_InsertAndRemoveLargeFile InsertAndRemoveLargeFile
-#endif
-TEST_F(FPDFEditEmbedderTest, MAYBE_InsertAndRemoveLargeFile) {
+TEST_F(FPDFEditEmbedderTest, InsertAndRemoveLargeFile) {
   const int kOriginalObjectCount = 600;
 
   // Load document with many objects.
@@ -1734,7 +1728,11 @@
 
   // Verify the black rectangle was added.
   ASSERT_EQ(kOriginalObjectCount + 1, FPDFPage_CountObjects(page));
+#if defined(_SKIA_SUPPORT_) || defined(_SKIA_SUPPORT_PATHS_)
+  const char kPlusRectangleMD5[] = "0d3715fcfb9bd0dd25dcce60800bff47";
+#else
   const char kPlusRectangleMD5[] = "6b9396ab570754b32b04ca629e902f77";
+#endif
   {
     ScopedFPDFBitmap page_bitmap = RenderPage(page);
     CompareBitmap(page_bitmap.get(), 200, 300, kPlusRectangleMD5);