commit 8fc2c9efb9016ce059d4d9365591740f71e7ca27
author Lei Zhang <thestig@chromium.org> Mon Mar 11 21:16:24 2024 +0000
committer Pdfium LUCI CQ <pdfium-scoped@luci-project-accounts.iam.gserviceaccount.com> Mon Mar 11 21:16:24 2024 +0000
tree 435ebf5471cc7bf43f28dd9acf5ff5e4b80a8b41
parent 6fa344b5e3e88f35402bb832f273e3d6b8e12b16

Rename CPDF_PatternCS::GetPatternRGB() to GetPatternColorRef()

Since the return type is std::optional<FX_COLORREF>.

Change-Id: I0127ef05bd4b77dd1ec72c764665bf49b08f9a9f
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/117392
Commit-Queue: Lei Zhang <thestig@chromium.org>
Reviewed-by: Thomas Sepez <tsepez@google.com>

core/fpdfapi/page/cpdf_color.cpp

diff --git a/core/fpdfapi/page/cpdf_color.cpp b/core/fpdfapi/page/cpdf_color.cpp
index 73bc00f..5a1896d 100644
--- a/core/fpdfapi/page/cpdf_color.cpp
+++ b/core/fpdfapi/page/cpdf_color.cpp
@@ -82,7 +82,7 @@
 std::optional<FX_COLORREF> CPDF_Color::GetRGB() const {
   if (IsPatternInternal()) {
     if (m_pValue) {
-      return m_pCS->AsPatternCS()->GetPatternRGB(*m_pValue);
+      return m_pCS->AsPatternCS()->GetPatternColorRef(*m_pValue);
     }
   } else {
     if (!m_Buffer.empty()) {

core/fpdfapi/page/cpdf_colorspace.h

diff --git a/core/fpdfapi/page/cpdf_colorspace.h b/core/fpdfapi/page/cpdf_colorspace.h
index 8be74e5..5a378ae 100644
--- a/core/fpdfapi/page/cpdf_colorspace.h
+++ b/core/fpdfapi/page/cpdf_colorspace.h
@@ -108,7 +108,7 @@
   // components are integers.
   std::optional<FX_COLORREF> GetColorRef(pdfium::span<const float> buffer);
 
-  // Use CPDF_Pattern::GetPatternRGB() instead of GetRGB() for patterns.
+  // Use CPDF_Pattern::GetPatternColorRef() instead of GetRGB() for patterns.
   virtual bool GetRGB(pdfium::span<const float> pBuf,
                       float* R,
                       float* G,

core/fpdfapi/page/cpdf_patterncs.cpp

diff --git a/core/fpdfapi/page/cpdf_patterncs.cpp b/core/fpdfapi/page/cpdf_patterncs.cpp
index c358862..fea5416 100644
--- a/core/fpdfapi/page/cpdf_patterncs.cpp
+++ b/core/fpdfapi/page/cpdf_patterncs.cpp
@@ -55,7 +55,7 @@
   return this;
 }
 
-std::optional<FX_COLORREF> CPDF_PatternCS::GetPatternRGB(
+std::optional<FX_COLORREF> CPDF_PatternCS::GetPatternColorRef(
     const PatternValue& value) const {
   if (!m_pBaseCS) {
     return std::nullopt;

core/fpdfapi/page/cpdf_patterncs.h

diff --git a/core/fpdfapi/page/cpdf_patterncs.h b/core/fpdfapi/page/cpdf_patterncs.h
index 2fba834..07d6f54 100644
--- a/core/fpdfapi/page/cpdf_patterncs.h
+++ b/core/fpdfapi/page/cpdf_patterncs.h
@@ -35,7 +35,8 @@
                   const CPDF_Array* pArray,
                   std::set<const CPDF_Object*>* pVisited) override;
 
-  std::optional<FX_COLORREF> GetPatternRGB(const PatternValue& value) const;
+  std::optional<FX_COLORREF> GetPatternColorRef(
+      const PatternValue& value) const;
 
  private:
   CPDF_PatternCS();