commit 97a5abdc3c32dc45be30a7adf01c6a888caac7d6
author Lei Zhang <thestig@chromium.org> Fri Feb 24 06:42:52 2023 +0000
committer Pdfium LUCI CQ <pdfium-scoped@luci-project-accounts.iam.gserviceaccount.com> Fri Feb 24 06:42:52 2023 +0000
tree b04bea22e7f1ec692950aa507885c275b053f269
parent aa2ec3591661caade2d90b5308b0f9f473cfae09

Use more form field constants in fpdf_signature.cpp

Use constants from constants/form_fields.h.

Change-Id: I5a526f07ef10304c57168fda1872c85e69300278
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/104090
Reviewed-by: Nigi <nigi@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>

fpdfsdk/fpdf_signature.cpp

diff --git a/fpdfsdk/fpdf_signature.cpp b/fpdfsdk/fpdf_signature.cpp
index 3c5777d..0a078b0 100644
--- a/fpdfsdk/fpdf_signature.cpp
+++ b/fpdfsdk/fpdf_signature.cpp
@@ -7,6 +7,7 @@
 #include <utility>
 #include <vector>
 
+#include "constants/form_fields.h"
 #include "core/fpdfapi/parser/cpdf_array.h"
 #include "core/fpdfapi/parser/cpdf_dictionary.h"
 #include "core/fpdfapi/parser/cpdf_document.h"
@@ -33,8 +34,10 @@
   CPDF_ArrayLocker locker(std::move(fields));
   for (auto& field : locker) {
     RetainPtr<CPDF_Dictionary> field_dict = field->GetMutableDict();
-    if (field_dict && field_dict->GetNameFor("FT") == "Sig")
+    if (field_dict && field_dict->GetNameFor(pdfium::form_fields::kFT) ==
+                          pdfium::form_fields::kSig) {
       signatures.push_back(std::move(field_dict));
+    }
   }
   return signatures;
 }
@@ -71,7 +74,8 @@
   if (!signature_dict)
     return 0;
 
-  RetainPtr<const CPDF_Dictionary> value_dict = signature_dict->GetDictFor("V");
+  RetainPtr<const CPDF_Dictionary> value_dict =
+      signature_dict->GetDictFor(pdfium::form_fields::kV);
   if (!value_dict)
     return 0;
 
@@ -93,7 +97,8 @@
   if (!signature_dict)
     return 0;
 
-  RetainPtr<const CPDF_Dictionary> value_dict = signature_dict->GetDictFor("V");
+  RetainPtr<const CPDF_Dictionary> value_dict =
+      signature_dict->GetDictFor(pdfium::form_fields::kV);
   if (!value_dict)
     return 0;
 
@@ -119,7 +124,8 @@
   if (!signature_dict)
     return 0;
 
-  RetainPtr<const CPDF_Dictionary> value_dict = signature_dict->GetDictFor("V");
+  RetainPtr<const CPDF_Dictionary> value_dict =
+      signature_dict->GetDictFor(pdfium::form_fields::kV);
   if (!value_dict || !value_dict->KeyExist("SubFilter"))
     return 0;
 
@@ -136,7 +142,8 @@
   if (!signature_dict)
     return 0;
 
-  RetainPtr<const CPDF_Dictionary> value_dict = signature_dict->GetDictFor("V");
+  RetainPtr<const CPDF_Dictionary> value_dict =
+      signature_dict->GetDictFor(pdfium::form_fields::kV);
   if (!value_dict)
     return 0;
 
@@ -157,7 +164,8 @@
   if (!signature_dict)
     return 0;
 
-  RetainPtr<const CPDF_Dictionary> value_dict = signature_dict->GetDictFor("V");
+  RetainPtr<const CPDF_Dictionary> value_dict =
+      signature_dict->GetDictFor(pdfium::form_fields::kV);
   if (!value_dict)
     return 0;
 
@@ -176,7 +184,8 @@
   if (!signature_dict)
     return permission;
 
-  RetainPtr<const CPDF_Dictionary> value_dict = signature_dict->GetDictFor("V");
+  RetainPtr<const CPDF_Dictionary> value_dict =
+      signature_dict->GetDictFor(pdfium::form_fields::kV);
   if (!value_dict)
     return permission;