commit b349032c24e3cea28870a697b0386b0187d4ac1e
author Hui Yingst <nigi@chromium.org> Wed Jul 22 00:53:29 2020 +0000
committer Chromium commit bot <commit-bot@chromium.org> Wed Jul 22 00:53:29 2020 +0000
tree c1077ea53eea18f436852f1ec5dc5ff3fff414d4
parent 1b6a47d7b52267f3d0a8906fb5d58367c41b1aaf

Enable FPDFAnnotEmbedderTest.AddAndSaveUnderlineAnnotation for Skia/SkiaPaths.

For test FPDFAnnotEmbedderTest.AddAndSaveUnderlineAnnotation, Skia and
SkiaPaths rendering results are acceptable but they don't match AGG's
expected results because they use different methods to load glyphs and
handle anti-alising on drawing paths. Therefore this CL adds the
Skia/SkiaPaths expected checksum value for this embeddertest so that it
can be enabled for Skia and SkiaPaths.

Bug: pdfium:1500
Change-Id: Ibd50de8cd846fe9fedde0400cdc79abb1bc09fb2
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/71811
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Hui Yingst <nigi@chromium.org>

fpdfsdk/fpdf_annot_embeddertest.cpp

diff --git a/fpdfsdk/fpdf_annot_embeddertest.cpp b/fpdfsdk/fpdf_annot_embeddertest.cpp
index 7ed02ee..c1917a6 100644
--- a/fpdfsdk/fpdf_annot_embeddertest.cpp
+++ b/fpdfsdk/fpdf_annot_embeddertest.cpp
@@ -663,14 +663,7 @@
   UnloadPage(page);
 }
 
-// TODO(crbug.com/pdfium/11): Fix this test and enable.
-#if defined(_SKIA_SUPPORT_) || defined(_SKIA_SUPPORT_PATHS_)
-#define MAYBE_AddAndSaveUnderlineAnnotation \
-  DISABLED_AddAndSaveUnderlineAnnotation
-#else
-#define MAYBE_AddAndSaveUnderlineAnnotation AddAndSaveUnderlineAnnotation
-#endif
-TEST_F(FPDFAnnotEmbedderTest, MAYBE_AddAndSaveUnderlineAnnotation) {
+TEST_F(FPDFAnnotEmbedderTest, AddAndSaveUnderlineAnnotation) {
   // Open a file with one annotation and load its first page.
   ASSERT_TRUE(OpenDocument("annotation_highlight_long_content.pdf"));
   FPDF_PAGE page = LoadPage(0);
@@ -705,11 +698,15 @@
   UnloadPage(page);
 
   // Open the saved document.
-  static const char kMd5[] = "dba153419f67b7c0c0e3d22d3e8910d5";
+#if defined(_SKIA_SUPPORT_) || defined(_SKIA_SUPPORT_PATHS_)
+  static const char kChecksum[] = "798fa41303381c9ba6d99092f5cd4d2b";
+#else
+  static const char kChecksum[] = "dba153419f67b7c0c0e3d22d3e8910d5";
+#endif
 
   ASSERT_TRUE(OpenSavedDocument());
   page = LoadSavedPage(0);
-  VerifySavedRendering(page, 612, 792, kMd5);
+  VerifySavedRendering(page, 612, 792, kChecksum);
 
   // Check that the saved document has 2 annotations on the first page
   EXPECT_EQ(2, FPDFPage_GetAnnotCount(page));