commit d563855ac72ba9dcec7f111587d6efaafc715b0d
author Ryan Harrison <rharrison@chromium.org> Tue Jul 17 20:03:29 2018 +0000
committer Chromium commit bot <commit-bot@chromium.org> Tue Jul 17 20:03:29 2018 +0000
tree e72a0031df7220514e4b817ad76afa1f341a27ca
parent a97a660d47cd500a00f69ad429de0ca1551c7198

Cleanup SetSavedCalled API

Fix a couple of post submit comments on the originally version of this
API.

BUG=pdfium:953

Change-Id: Id5b7480c5791821340366371b4ab861e78d47e8b
Reviewed-on: https://pdfium-review.googlesource.com/38150
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Ryan Harrison <rharrison@chromium.org>

fpdfsdk/fpdf_formfill.cpp

diff --git a/fpdfsdk/fpdf_formfill.cpp b/fpdfsdk/fpdf_formfill.cpp
index 1af34b5..d529a5b 100644
--- a/fpdfsdk/fpdf_formfill.cpp
+++ b/fpdfsdk/fpdf_formfill.cpp
@@ -360,8 +360,8 @@
   delete pFormFillEnv;
 }
 
-FPDF_EXPORT void FPDF_CALLCONV FORM_SetSaveCallback(FORM_SAVECALLED callback,
-                                                    FPDF_FORMHANDLE hHandle) {
+FPDF_EXPORT void FPDF_CALLCONV FORM_SetSaveCallback(FPDF_FORMHANDLE hHandle,
+                                                    FORM_SAVECALLED callback) {
   CPDFSDK_FormFillEnvironment* pFormFillEnv =
       HandleToCPDFSDKEnvironment(hHandle);
   if (!pFormFillEnv)

public/fpdf_formfill.h

diff --git a/public/fpdf_formfill.h b/public/fpdf_formfill.h
index 68ffcda..4a703d9 100644
--- a/public/fpdf_formfill.h
+++ b/public/fpdf_formfill.h
@@ -1122,16 +1122,16 @@
  *          loaded a PDF page, and method FPDFDOC_InitFormFillEnvironment had
  *          been invoked.
  * Parameters:
- *          callback    -   Function pointer to the callback to be called when a
- *                          Save is attempted. If NULL then no function will be
- *                          invoked..
  *          hHandle     -   Handle to the form fill module. Returned by
  *                          FPDFDOC_InitFormFillEnvironment.
+ *          callback    -   Function pointer to the callback to be called when a
+ *                          Save is attempted. If NULL then no function will be
+ *                          invoked.
  * Return Value:
  *          NONE.
  **/
-FPDF_EXPORT void FPDF_CALLCONV FORM_SetSaveCallback(FORM_SAVECALLED callback,
-                                                    FPDF_FORMHANDLE hHandle);
+FPDF_EXPORT void FPDF_CALLCONV FORM_SetSaveCallback(FPDF_FORMHANDLE hHandle,
+                                                    FORM_SAVECALLED callback);
 
 /**
  * Function: FORM_OnAfterLoadPage