commit da14fcb53749d922853e2873e20e5eb80adb580a
author Tom Sepez <tsepez@chromium.org> Wed Jan 03 18:53:45 2024 +0000
committer Pdfium LUCI CQ <pdfium-scoped@luci-project-accounts.iam.gserviceaccount.com> Wed Jan 03 18:53:45 2024 +0000
tree b0a676bba9f39250b22fccb458924193e4d8b482
parent 4821f9fb82bd0290ece5cbe472a762816eecce72

Simplify matcher string in fxcrt death tests

Note that "" is an acceptable matcher for all error strings in place
of ".*".

Change-Id: I81503162ef9376d92e3dee2b2a1b158a4119e45e
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/115131
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>

core/fxcrt/bytestring_unittest.cpp

diff --git a/core/fxcrt/bytestring_unittest.cpp b/core/fxcrt/bytestring_unittest.cpp
index 6411d9b..a66959e 100644
--- a/core/fxcrt/bytestring_unittest.cpp
+++ b/core/fxcrt/bytestring_unittest.cpp
@@ -25,7 +25,7 @@
   EXPECT_EQ('b', abc[1]);
   EXPECT_EQ('c', abc[2]);
 #ifndef NDEBUG
-  EXPECT_DEATH({ abc[3]; }, ".*");
+  EXPECT_DEATH({ abc[3]; }, "");
 #endif
 
   pdfium::span<const char> abc_span = abc.span();
@@ -59,7 +59,7 @@
   EXPECT_EQ("abc", abc);
   EXPECT_EQ("def", mutable_abc);
 #ifndef NDEBUG
-  EXPECT_DEATH({ mutable_abc.SetAt(3, 'g'); }, ".*");
+  EXPECT_DEATH({ mutable_abc.SetAt(3, 'g'); }, "");
   EXPECT_EQ("abc", abc);
 #endif
 }
@@ -1403,7 +1403,7 @@
   EXPECT_EQ('b', static_cast<char>(abc[1]));
   EXPECT_EQ('c', static_cast<char>(abc[2]));
 #ifndef NDEBUG
-  EXPECT_DEATH({ abc[3]; }, ".*");
+  EXPECT_DEATH({ abc[3]; }, "");
 #endif
 }
 

core/fxcrt/pdfium_span_unittest.cpp

diff --git a/core/fxcrt/pdfium_span_unittest.cpp b/core/fxcrt/pdfium_span_unittest.cpp
index b1bfe7d..9f1134d 100644
--- a/core/fxcrt/pdfium_span_unittest.cpp
+++ b/core/fxcrt/pdfium_span_unittest.cpp
@@ -40,17 +40,17 @@
 
 TEST(PdfiumSpanDeathTest, EmptySpanIndex) {
   pdfium::span<int> empty_span;
-  EXPECT_DEATH(empty_span[0] += 1, ".*");
+  EXPECT_DEATH(empty_span[0] += 1, "");
 }
 
 TEST(PdfiumSpanDeathTest, EmptySpanFront) {
   pdfium::span<int> empty_span;
-  EXPECT_DEATH(empty_span.front() += 1, ".*");
+  EXPECT_DEATH(empty_span.front() += 1, "");
 }
 
 TEST(PdfiumSpanDeathTest, EmptySpanBack) {
   pdfium::span<int> empty_span;
-  EXPECT_DEATH(empty_span.back() += 1, ".*");
+  EXPECT_DEATH(empty_span.back() += 1, "");
 }
 
 #if defined(UNOWNED_PTR_DANGLING_CHECKS)
@@ -67,6 +67,6 @@
 }  // namespace
 
 TEST(PdfiumSpanDeathTest, DanglingReference) {
-  EXPECT_DEATH(CreateDanglingSpan(), ".*");
+  EXPECT_DEATH(CreateDanglingSpan(), "");
 }
 #endif  // defined(UNOWNED_PTR_DANGLING_CHECKS)

core/fxcrt/widestring_unittest.cpp

diff --git a/core/fxcrt/widestring_unittest.cpp b/core/fxcrt/widestring_unittest.cpp
index 39d734b..f8e3b9a 100644
--- a/core/fxcrt/widestring_unittest.cpp
+++ b/core/fxcrt/widestring_unittest.cpp
@@ -23,7 +23,7 @@
   EXPECT_EQ(L'b', abc[1]);
   EXPECT_EQ(L'c', abc[2]);
 #ifndef NDEBUG
-  EXPECT_DEATH({ abc[4]; }, ".*");
+  EXPECT_DEATH({ abc[4]; }, "");
 #endif
 
   pdfium::span<const wchar_t> abc_span = abc.span();
@@ -53,7 +53,7 @@
   EXPECT_EQ(L"abc", abc);
   EXPECT_EQ(L"def", mutable_abc);
 #ifndef NDEBUG
-  EXPECT_DEATH({ mutable_abc.SetAt(3, L'g'); }, ".*");
+  EXPECT_DEATH({ mutable_abc.SetAt(3, L'g'); }, "");
   EXPECT_EQ(L"abc", abc);
 #endif
 }
@@ -1452,7 +1452,7 @@
   EXPECT_EQ(L'b', static_cast<wchar_t>(abc[1]));
   EXPECT_EQ(L'c', static_cast<wchar_t>(abc[2]));
 #ifndef NDEBUG
-  EXPECT_DEATH({ abc[4]; }, ".*");
+  EXPECT_DEATH({ abc[4]; }, "");
 #endif
 }