commit e782e37b182c767925a750dfad5aa8fe979936b4
author Lei Zhang <thestig@chromium.org> Mon May 11 21:47:38 2020 +0000
committer Chromium commit bot <commit-bot@chromium.org> Mon May 11 21:47:38 2020 +0000
tree 4ce88c681d6440dd88d02f3523c23fba746f0e10
parent 3ea38438da69868f33aac23ce7d1b3575479fb0a

Remove 0-parameter CPDF_Dest() constructor.

It's the same as CPDF_Dest(nullptr).

Change-Id: I6708c3d8c3e95e2d722bd4e4f1ba5cc3da59e8a9
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/69731
Commit-Queue: Lei Zhang <thestig@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>

core/fpdfdoc/cpdf_action.cpp

diff --git a/core/fpdfdoc/cpdf_action.cpp b/core/fpdfdoc/cpdf_action.cpp
index 0b1b96e..9166b7c 100644
--- a/core/fpdfdoc/cpdf_action.cpp
+++ b/core/fpdfdoc/cpdf_action.cpp
@@ -55,7 +55,7 @@
 CPDF_Dest CPDF_Action::GetDest(CPDF_Document* pDoc) const {
   ActionType type = GetType();
   if (type != GoTo && type != GoToR)
-    return CPDF_Dest();
+    return CPDF_Dest(nullptr);
   return CPDF_Dest::Create(pDoc, m_pDict->GetDirectObjectFor("D"));
 }
 

core/fpdfdoc/cpdf_bookmark.cpp

diff --git a/core/fpdfdoc/cpdf_bookmark.cpp b/core/fpdfdoc/cpdf_bookmark.cpp
index 2f8d5c3..9c8a553 100644
--- a/core/fpdfdoc/cpdf_bookmark.cpp
+++ b/core/fpdfdoc/cpdf_bookmark.cpp
@@ -45,7 +45,7 @@
 
 CPDF_Dest CPDF_Bookmark::GetDest(CPDF_Document* pDocument) const {
   if (!m_pDict)
-    return CPDF_Dest();
+    return CPDF_Dest(nullptr);
   return CPDF_Dest::Create(pDocument, m_pDict->GetDirectObjectFor("Dest"));
 }
 

core/fpdfdoc/cpdf_dest.cpp

diff --git a/core/fpdfdoc/cpdf_dest.cpp b/core/fpdfdoc/cpdf_dest.cpp
index 388355e..f0c3592 100644
--- a/core/fpdfdoc/cpdf_dest.cpp
+++ b/core/fpdfdoc/cpdf_dest.cpp
@@ -32,8 +32,6 @@
 
 }  // namespace
 
-CPDF_Dest::CPDF_Dest() {}
-
 CPDF_Dest::CPDF_Dest(const CPDF_Array* pArray) : m_pArray(pArray) {}
 
 CPDF_Dest::CPDF_Dest(const CPDF_Dest& that) = default;
@@ -43,7 +41,7 @@
 // static
 CPDF_Dest CPDF_Dest::Create(CPDF_Document* pDoc, const CPDF_Object* pDest) {
   if (!pDest)
-    return CPDF_Dest();
+    return CPDF_Dest(nullptr);
 
   if (pDest->IsString() || pDest->IsName())
     return CPDF_Dest(CPDF_NameTree::LookupNamedDest(pDoc, pDest->GetString()));

core/fpdfdoc/cpdf_dest.h

diff --git a/core/fpdfdoc/cpdf_dest.h b/core/fpdfdoc/cpdf_dest.h
index 0734182..e70a454 100644
--- a/core/fpdfdoc/cpdf_dest.h
+++ b/core/fpdfdoc/cpdf_dest.h
@@ -16,7 +16,6 @@
 
 class CPDF_Dest {
  public:
-  CPDF_Dest();
   explicit CPDF_Dest(const CPDF_Array* pArray);
   CPDF_Dest(const CPDF_Dest& that);
   ~CPDF_Dest();

core/fpdfdoc/cpdf_dest_unittest.cpp

diff --git a/core/fpdfdoc/cpdf_dest_unittest.cpp b/core/fpdfdoc/cpdf_dest_unittest.cpp
index 265b939..752a681 100644
--- a/core/fpdfdoc/cpdf_dest_unittest.cpp
+++ b/core/fpdfdoc/cpdf_dest_unittest.cpp
@@ -25,7 +25,7 @@
   array->AppendNew<CPDF_Name>("XYZ");
   array->AppendNew<CPDF_Number>(4);  // X
   {
-    auto dest = pdfium::MakeUnique<CPDF_Dest>();
+    auto dest = pdfium::MakeUnique<CPDF_Dest>(nullptr);
     EXPECT_FALSE(dest->GetXYZ(&hasX, &hasY, &hasZoom, &x, &y, &zoom));
   }
   {

fpdfsdk/cpdfsdk_baannot.cpp

diff --git a/fpdfsdk/cpdfsdk_baannot.cpp b/fpdfsdk/cpdfsdk_baannot.cpp
index 43b3a7b..524eccd 100644
--- a/fpdfsdk/cpdfsdk_baannot.cpp
+++ b/fpdfsdk/cpdfsdk_baannot.cpp
@@ -232,10 +232,10 @@
 
 CPDF_Dest CPDFSDK_BAAnnot::GetDestination() const {
   if (m_pAnnot->GetSubtype() != CPDF_Annot::Subtype::LINK)
-    return CPDF_Dest();
+    return CPDF_Dest(nullptr);
 
   // Link annotations can have "Dest" entry defined as an explicit array.
   // https://www.adobe.com/content/dam/acom/en/devnet/pdf/pdfs/PDF32000_2008.pdf#page=373
   return CPDF_Dest::Create(m_pPageView->GetPDFDocument(),
                            GetAnnotDict()->GetDirectObjectFor("Dest"));
-}
\ No newline at end of file
+}