Simply _CheckIncludeOrder() presubmit check. Calling input_api.FilterSourceFile() with the optional |black_list| parameter set to |input_api.DEFAULT_BLACK_LIST| is the same as not passing it at all. So remove it in FileFilterIncludeOrder(). Then FileFilterIncludeOrder() just becomes a trivial wrapper around input_api.FilterSourceFile(), so remove FileFilterIncludeOrder() altogether. Change-Id: I65e85fcba2bcad6548966deb36f95f039bf5de5e Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/73073 Reviewed-by: Daniel Hosseinian <dhoss@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org>
diff --git a/PRESUBMIT.py b/PRESUBMIT.py index f87de6d..2ab1923 100644 --- a/PRESUBMIT.py +++ b/PRESUBMIT.py
@@ -251,12 +251,8 @@ Each region separated by #if, #elif, #else, #endif, #define and #undef follows these rules separately. """ - def FileFilterIncludeOrder(affected_file): - black_list = (input_api.DEFAULT_BLACK_LIST) - return input_api.FilterSourceFile(affected_file, black_list=black_list) - warnings = [] - for f in input_api.AffectedFiles(file_filter=FileFilterIncludeOrder): + for f in input_api.AffectedFiles(file_filter=input_api.FilterSourceFile): if f.LocalPath().endswith(('.cc', '.cpp', '.h', '.mm')): changed_linenums = set(line_num for line_num, _ in f.ChangedContents()) warnings.extend(_CheckIncludeOrderInFile(input_api, f, changed_linenums)) @@ -267,6 +263,7 @@ warnings)) return results + def _CheckTestDuplicates(input_api, output_api): """Checks that pixel and javascript tests don't contain duplicates. We use .in and .pdf files, having both can cause race conditions on the bots,