core: fix two more uninitialized members Found by Coverity when scanning the bundled pdfium-3004 in LibreOffice. This fixes: - CID 1400335: Uninitialized members (UNINIT_CTOR) CPDF_DataAvail::m_dwTrailerOffset - CID 1400334: Uninitialized members (UNINIT_CTOR) CXML_Element::m_pParent Change-Id: I42da9a704ad75adf39c510c6ef89eb7a97860ea1 Reviewed-on: https://pdfium-review.googlesource.com/2670 Reviewed-by: Lei Zhang <thestig@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org>
diff --git a/AUTHORS b/AUTHORS index 17a0c60..6c2a295 100644 --- a/AUTHORS +++ b/AUTHORS
@@ -27,6 +27,7 @@ Lucas Nihlen <luken@chromium.org> Matt Giuca <mgiuca@chromium.org> Michael Doppler <m.doppler@gmail.com> +Miklos Vajna <vmiklos@vmiklos.hu> Nico Weber <thakis@chromium.org> Peter Kasting <pkasting@chromium.org> Raymes Khoury <raymes@chromium.org>
diff --git a/core/fpdfapi/parser/cpdf_data_avail.cpp b/core/fpdfapi/parser/cpdf_data_avail.cpp index 4205ed2..c6ecae9 100644 --- a/core/fpdfapi/parser/cpdf_data_avail.cpp +++ b/core/fpdfapi/parser/cpdf_data_avail.cpp
@@ -46,6 +46,7 @@ } m_dwCurrentOffset = 0; m_dwXRefOffset = 0; + m_dwTrailerOffset = 0; m_bufferOffset = 0; m_bufferSize = 0; m_PagesObjNum = 0;
diff --git a/core/fxcrt/fx_xml.h b/core/fxcrt/fx_xml.h index 7f42a7f..38a1b60 100644 --- a/core/fxcrt/fx_xml.h +++ b/core/fxcrt/fx_xml.h
@@ -66,8 +66,6 @@ bool bSaveSpaceChars = false, FX_FILESIZE* pParsedSize = nullptr); - CXML_Element(const CFX_ByteStringC& qSpace, const CFX_ByteStringC& tagName); - explicit CXML_Element(const CFX_ByteStringC& qTagName); CXML_Element(); ~CXML_Element();
diff --git a/core/fxcrt/fx_xml_parser.cpp b/core/fxcrt/fx_xml_parser.cpp index 7658620..2250087 100644 --- a/core/fxcrt/fx_xml_parser.cpp +++ b/core/fxcrt/fx_xml_parser.cpp
@@ -715,17 +715,8 @@ return XML_ContinueParse(parser, bSaveSpaceChars, pParsedSize); } -CXML_Element::CXML_Element() : m_QSpaceName(), m_TagName(), m_AttrMap() {} -CXML_Element::CXML_Element(const CFX_ByteStringC& qSpace, - const CFX_ByteStringC& tagName) - : m_QSpaceName(), m_TagName(), m_AttrMap() { - m_QSpaceName = qSpace; - m_TagName = tagName; -} -CXML_Element::CXML_Element(const CFX_ByteStringC& qTagName) - : m_pParent(nullptr), m_QSpaceName(), m_TagName(), m_AttrMap() { - SetTag(qTagName); -} +CXML_Element::CXML_Element() + : m_pParent(nullptr), m_QSpaceName(), m_TagName(), m_AttrMap() {} CXML_Element::~CXML_Element() { Empty(); }