Fix how NamedPropertySetterCallback returns result V8 will prohibit calling ReturnValue<void>::Set(Local<S>) which used to indicate whether the request was intercepted while the value was not relevant. With the new interceptor Api the callback explicitly returns v8::Intercepted::kYes/kNo and calling Set just for that is not necessary. Bug: 348660658 Change-Id: I960efb682bdab45a288e965d887dbdb7aff32433 Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/120870 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by: Tom Sepez <tsepez@chromium.org> Reviewed-by: Lei Zhang <thestig@chromium.org> Reviewed-by: Thomas Sepez <tsepez@google.com>
diff --git a/fxjs/cjs_global.cpp b/fxjs/cjs_global.cpp index dd0e271..79a89a6 100644 --- a/fxjs/cjs_global.cpp +++ b/fxjs/cjs_global.cpp
@@ -118,8 +118,6 @@ JSFormatErrorString("global", "PutProperty", result.Error())); return v8::Intercepted::kYes; } - - info.GetReturnValue().Set(value); return v8::Intercepted::kYes; }
diff --git a/fxjs/xfa/cfxjse_class.cpp b/fxjs/xfa/cfxjse_class.cpp index adb3d48..0397cc2 100644 --- a/fxjs/xfa/cfxjse_class.cpp +++ b/fxjs/xfa/cfxjse_class.cpp
@@ -252,7 +252,6 @@ auto pNewValue = std::make_unique<CFXJSE_Value>(info.GetIsolate(), value); DynPropSetterAdapter(info.GetIsolate(), pClass, info.Holder(), szFxPropName, pNewValue.get()); - info.GetReturnValue().Set(value); return v8::Intercepted::kYes; }