Update CPDF_Number member names Rename `m_Number` to `number_` to match the Google C++ style guide. Change-Id: I6df3729283e8a6079ab9712872ad237c3087d95c Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/124271 Commit-Queue: Andy Phan <andyphan@chromium.org> Reviewed-by: Lei Zhang <thestig@chromium.org>
diff --git a/core/fpdfapi/parser/cpdf_number.cpp b/core/fpdfapi/parser/cpdf_number.cpp index 6b9d78d..50e626d 100644 --- a/core/fpdfapi/parser/cpdf_number.cpp +++ b/core/fpdfapi/parser/cpdf_number.cpp
@@ -10,11 +10,11 @@ CPDF_Number::CPDF_Number() = default; -CPDF_Number::CPDF_Number(int value) : m_Number(value) {} +CPDF_Number::CPDF_Number(int value) : number_(value) {} -CPDF_Number::CPDF_Number(float value) : m_Number(value) {} +CPDF_Number::CPDF_Number(float value) : number_(value) {} -CPDF_Number::CPDF_Number(ByteStringView str) : m_Number(str) {} +CPDF_Number::CPDF_Number(ByteStringView str) : number_(str) {} CPDF_Number::~CPDF_Number() = default; @@ -23,17 +23,17 @@ } RetainPtr<CPDF_Object> CPDF_Number::Clone() const { - return m_Number.IsInteger() - ? pdfium::MakeRetain<CPDF_Number>(m_Number.GetSigned()) - : pdfium::MakeRetain<CPDF_Number>(m_Number.GetFloat()); + return number_.IsInteger() + ? pdfium::MakeRetain<CPDF_Number>(number_.GetSigned()) + : pdfium::MakeRetain<CPDF_Number>(number_.GetFloat()); } float CPDF_Number::GetNumber() const { - return m_Number.GetFloat(); + return number_.GetFloat(); } int CPDF_Number::GetInteger() const { - return m_Number.GetSigned(); + return number_.GetSigned(); } CPDF_Number* CPDF_Number::AsMutableNumber() { @@ -41,12 +41,12 @@ } void CPDF_Number::SetString(const ByteString& str) { - m_Number = FX_Number(str.AsStringView()); + number_ = FX_Number(str.AsStringView()); } ByteString CPDF_Number::GetString() const { - return m_Number.IsInteger() ? ByteString::FormatInteger(m_Number.GetSigned()) - : ByteString::FormatFloat(m_Number.GetFloat()); + return number_.IsInteger() ? ByteString::FormatInteger(number_.GetSigned()) + : ByteString::FormatFloat(number_.GetFloat()); } bool CPDF_Number::WriteTo(IFX_ArchiveStream* archive,
diff --git a/core/fpdfapi/parser/cpdf_number.h b/core/fpdfapi/parser/cpdf_number.h index 93b0f9d..b98f9c7 100644 --- a/core/fpdfapi/parser/cpdf_number.h +++ b/core/fpdfapi/parser/cpdf_number.h
@@ -27,7 +27,7 @@ bool WriteTo(IFX_ArchiveStream* archive, const CPDF_Encryptor* encryptor) const override; - bool IsInteger() const { return m_Number.IsInteger(); } + bool IsInteger() const { return number_.IsInteger(); } private: CPDF_Number(); @@ -36,7 +36,7 @@ explicit CPDF_Number(ByteStringView str); ~CPDF_Number() override; - FX_Number m_Number; + FX_Number number_; }; inline CPDF_Number* ToNumber(CPDF_Object* obj) {