Use functions for renderer-specific test hash values
Some rendering tests use a hash value to represent the expected result.
In some cases such values can be different depending upon whether AGG
or Skia renderer is used. At times this can also differ depending upon
the platform, such as for Apple products.
For cases where such hash values are reused in more than one test
function, encapsulate the selection of hash value in a function instead
of having tests directly use the hardcoded constant name. This is in
preparation for an update where the renderer to use could be determined
at runtime.
Bug: pdfium:11
Change-Id: I74508e7b868be6dee1fe2b24f28da4a072bc2492
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/94390
Reviewed-by: Nigi <nigi@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
diff --git a/core/fpdfapi/parser/cpdf_security_handler_embeddertest.cpp b/core/fpdfapi/parser/cpdf_security_handler_embeddertest.cpp
index 9471e15..10e01a3 100644
--- a/core/fpdfapi/parser/cpdf_security_handler_embeddertest.cpp
+++ b/core/fpdfapi/parser/cpdf_security_handler_embeddertest.cpp
@@ -93,7 +93,7 @@
ASSERT_TRUE(page);
ScopedFPDFBitmap page_bitmap = RenderPage(page);
- CompareBitmap(page_bitmap.get(), 200, 200, pdfium::kHelloWorldChecksum);
+ CompareBitmap(page_bitmap.get(), 200, 200, pdfium::HelloWorldChecksum());
}
void VerifyModifiedHelloWorldPage(FPDF_PAGE page) {
@@ -101,7 +101,7 @@
ScopedFPDFBitmap page_bitmap = RenderPage(page);
CompareBitmap(page_bitmap.get(), 200, 200,
- pdfium::kHelloWorldRemovedChecksum);
+ pdfium::HelloWorldRemovedChecksum());
}
};
diff --git a/core/fpdfapi/parser/fpdf_parser_decode_embeddertest.cpp b/core/fpdfapi/parser/fpdf_parser_decode_embeddertest.cpp
index b05fa15..2254fa0 100644
--- a/core/fpdfapi/parser/fpdf_parser_decode_embeddertest.cpp
+++ b/core/fpdfapi/parser/fpdf_parser_decode_embeddertest.cpp
@@ -43,6 +43,6 @@
ASSERT_TRUE(page);
ScopedFPDFBitmap bitmap = RenderLoadedPage(page);
- CompareBitmap(bitmap.get(), 200, 200, pdfium::kHelloWorldChecksum);
+ CompareBitmap(bitmap.get(), 200, 200, pdfium::HelloWorldChecksum());
UnloadPage(page);
}
diff --git a/core/fpdfapi/render/fpdf_progressive_render_embeddertest.cpp b/core/fpdfapi/render/fpdf_progressive_render_embeddertest.cpp
index 053cb9d..da3e0cd 100644
--- a/core/fpdfapi/render/fpdf_progressive_render_embeddertest.cpp
+++ b/core/fpdfapi/render/fpdf_progressive_render_embeddertest.cpp
@@ -22,15 +22,19 @@
constexpr FX_ARGB kRed = 0xFFFF0000;
constexpr FX_ARGB kWhite = 0xFFFFFFFF;
+const char* AnnotationStampWithApBaseContentChecksum() {
#if BUILDFLAG(IS_APPLE) && !defined(_SKIA_SUPPORT_) && \
!defined(_SKIA_SUPPORT_PATHS_)
-static constexpr char kAnnotationStampWithApBaseContentChecksum[] =
- "243f3d6267d9db09198fed9f8c4957fd";
+ static constexpr char kAnnotationStampWithApBaseContentChecksum[] =
+ "243f3d6267d9db09198fed9f8c4957fd";
#else
-static constexpr char kAnnotationStampWithApBaseContentChecksum[] =
- "e31414933c9ff3950773981e5bf61678";
+ static constexpr char kAnnotationStampWithApBaseContentChecksum[] =
+ "e31414933c9ff3950773981e5bf61678";
#endif
+ return kAnnotationStampWithApBaseContentChecksum;
+}
+
} // namespace
class FPDFProgressiveRenderEmbedderTest : public EmbedderTest {
@@ -229,7 +233,7 @@
EXPECT_TRUE(StartRenderPage(page, &pause));
ScopedFPDFBitmap bitmap = FinishRenderPage(page);
CompareBitmap(bitmap.get(), 595, 842,
- kAnnotationStampWithApBaseContentChecksum);
+ AnnotationStampWithApBaseContentChecksum());
UnloadPage(page);
}
@@ -248,7 +252,7 @@
}
ScopedFPDFBitmap bitmap = FinishRenderPage(page);
CompareBitmap(bitmap.get(), 595, 842,
- kAnnotationStampWithApBaseContentChecksum);
+ AnnotationStampWithApBaseContentChecksum());
UnloadPage(page);
}
@@ -266,7 +270,8 @@
render_done = ContinueRenderPage(page, &pause);
}
ScopedFPDFBitmap bitmap = FinishRenderPage(page);
- CompareBitmap(bitmap.get(), 595, 842, pdfium::kAnnotationStampWithApChecksum);
+ CompareBitmap(bitmap.get(), 595, 842,
+ pdfium::AnnotationStampWithApChecksum());
UnloadPage(page);
}
@@ -284,7 +289,7 @@
render_done = ContinueRenderPage(page, &pause);
}
ScopedFPDFBitmap bitmap = FinishRenderPageWithForms(page, form_handle());
- CompareBitmap(bitmap.get(), 300, 300, pdfium::kTextFormChecksum);
+ CompareBitmap(bitmap.get(), 300, 300, pdfium::TextFormChecksum());
UnloadPage(page);
}
diff --git a/fpdfsdk/fpdf_annot_embeddertest.cpp b/fpdfsdk/fpdf_annot_embeddertest.cpp
index 5646d42..e3e48be 100644
--- a/fpdfsdk/fpdf_annot_embeddertest.cpp
+++ b/fpdfsdk/fpdf_annot_embeddertest.cpp
@@ -30,7 +30,7 @@
#include "third_party/base/containers/contains.h"
#include "third_party/base/span.h"
-using pdfium::kAnnotationStampWithApChecksum;
+using pdfium::AnnotationStampWithApChecksum;
namespace {
@@ -657,7 +657,7 @@
ASSERT_TRUE(page);
{
ScopedFPDFBitmap bitmap = RenderLoadedPageWithFlags(page, FPDF_ANNOT);
- CompareBitmap(bitmap.get(), 200, 200, pdfium::kHelloWorldChecksum);
+ CompareBitmap(bitmap.get(), 200, 200, pdfium::HelloWorldChecksum());
}
EXPECT_EQ(0, FPDFPage_GetAnnotCount(page));
@@ -713,7 +713,7 @@
ASSERT_TRUE(OpenSavedDocument());
page = LoadSavedPage(0);
ASSERT_TRUE(page);
- VerifySavedRendering(page, 200, 200, pdfium::kHelloWorldChecksum);
+ VerifySavedRendering(page, 200, 200, pdfium::HelloWorldChecksum());
EXPECT_EQ(1, FPDFPage_GetAnnotCount(page));
{
@@ -1122,7 +1122,7 @@
// Check that the page renders correctly.
{
ScopedFPDFBitmap bitmap = RenderLoadedPageWithFlags(page, FPDF_ANNOT);
- CompareBitmap(bitmap.get(), 595, 842, kAnnotationStampWithApChecksum);
+ CompareBitmap(bitmap.get(), 595, 842, AnnotationStampWithApChecksum());
}
{
@@ -1335,7 +1335,7 @@
// Check that the page renders correctly.
{
ScopedFPDFBitmap bitmap = RenderLoadedPageWithFlags(page, FPDF_ANNOT);
- CompareBitmap(bitmap.get(), 595, 842, kAnnotationStampWithApChecksum);
+ CompareBitmap(bitmap.get(), 595, 842, AnnotationStampWithApChecksum());
}
constexpr int kBitmapSize = 200;
@@ -1421,7 +1421,7 @@
// Check that the page renders correctly.
{
ScopedFPDFBitmap bitmap = RenderLoadedPageWithFlags(page, FPDF_ANNOT);
- CompareBitmap(bitmap.get(), 595, 842, kAnnotationStampWithApChecksum);
+ CompareBitmap(bitmap.get(), 595, 842, AnnotationStampWithApChecksum());
}
{
@@ -1477,7 +1477,7 @@
EXPECT_TRUE(FPDFPage_RemoveAnnot(page, 2));
{
ScopedFPDFBitmap bitmap = RenderLoadedPageWithFlags(page, FPDF_ANNOT);
- CompareBitmap(bitmap.get(), 595, 842, kAnnotationStampWithApChecksum);
+ CompareBitmap(bitmap.get(), 595, 842, AnnotationStampWithApChecksum());
}
UnloadPage(page);
diff --git a/fpdfsdk/fpdf_edit_embeddertest.cpp b/fpdfsdk/fpdf_edit_embeddertest.cpp
index 070dadd..7875425 100644
--- a/fpdfsdk/fpdf_edit_embeddertest.cpp
+++ b/fpdfsdk/fpdf_edit_embeddertest.cpp
@@ -35,7 +35,7 @@
#include "testing/utils/path_service.h"
#include "third_party/base/check.h"
-using pdfium::kHelloWorldChecksum;
+using pdfium::HelloWorldChecksum;
namespace {
@@ -43,32 +43,49 @@
const wchar_t kBottomText[] = L"I'm at the bottom of the page";
+const char* BottomTextChecksum() {
#if BUILDFLAG(IS_APPLE) && !defined(_SKIA_SUPPORT_) && \
!defined(_SKIA_SUPPORT_PATHS_)
-static constexpr char kBottomTextChecksum[] =
- "81636489006a31fcb00cf29efcdf7909";
+ static constexpr char kBottomTextChecksum[] =
+ "81636489006a31fcb00cf29efcdf7909";
#else
-static constexpr char kBottomTextChecksum[] =
- "891dcb6e914c8360998055f1f47c9727";
+ static constexpr char kBottomTextChecksum[] =
+ "891dcb6e914c8360998055f1f47c9727";
#endif
+ return kBottomTextChecksum;
+}
+
+const char* FirstRemovedChecksum() {
#if BUILDFLAG(IS_APPLE) && !defined(_SKIA_SUPPORT_) && \
!defined(_SKIA_SUPPORT_PATHS_)
-const char kFirstRemovedChecksum[] = "a1dc2812692fcc7ee4f01ca77435df9d";
+ static constexpr char kFirstRemovedChecksum[] =
+ "a1dc2812692fcc7ee4f01ca77435df9d";
#else
-const char kFirstRemovedChecksum[] = "e1477dc3b5b3b9c560814c4d1135a02b";
+ static constexpr char kFirstRemovedChecksum[] =
+ "e1477dc3b5b3b9c560814c4d1135a02b";
#endif
+ return kFirstRemovedChecksum;
+}
+
const wchar_t kLoadedFontText[] = L"I am testing my loaded font, WEE.";
+const char* LoadedFontTextChecksum() {
#if defined(_SKIA_SUPPORT_) || defined(_SKIA_SUPPORT_PATHS_)
-const char kLoadedFontTextChecksum[] = "d58570cc045dfb818b92cbabbd1a364c";
+ static constexpr char kLoadedFontTextChecksum[] =
+ "d58570cc045dfb818b92cbabbd1a364c";
#elif BUILDFLAG(IS_APPLE)
-const char kLoadedFontTextChecksum[] = "0f3e4a7d71f9e7eb8a1a0d69403b9848";
+ static constexpr char kLoadedFontTextChecksum[] =
+ "0f3e4a7d71f9e7eb8a1a0d69403b9848";
#else
-const char kLoadedFontTextChecksum[] = "d58570cc045dfb818b92cbabbd1a364c";
+ static constexpr char kLoadedFontTextChecksum[] =
+ "d58570cc045dfb818b92cbabbd1a364c";
#endif
+ return kLoadedFontTextChecksum;
+}
+
const char kRedRectangleChecksum[] = "66d02eaa6181e2c069ce2ea99beda497";
// In embedded_images.pdf.
@@ -898,7 +915,7 @@
// Show what the original file looks like.
{
ScopedFPDFBitmap page_bitmap = RenderPage(page);
- CompareBitmap(page_bitmap.get(), 200, 200, kHelloWorldChecksum);
+ CompareBitmap(page_bitmap.get(), 200, 200, HelloWorldChecksum());
}
// Get the "Hello, world!" text object and remove it.
@@ -910,7 +927,7 @@
// Verify the "Hello, world!" text is gone.
{
ScopedFPDFBitmap page_bitmap = RenderPage(page);
- CompareBitmap(page_bitmap.get(), 200, 200, kFirstRemovedChecksum);
+ CompareBitmap(page_bitmap.get(), 200, 200, FirstRemovedChecksum());
}
ASSERT_EQ(1, FPDFPage_CountObjects(page));
@@ -1424,7 +1441,7 @@
ASSERT_EQ(2, FPDFPage_CountObjects(page));
{
ScopedFPDFBitmap page_bitmap = RenderPage(page);
- CompareBitmap(page_bitmap.get(), 200, 200, kHelloWorldChecksum);
+ CompareBitmap(page_bitmap.get(), 200, 200, HelloWorldChecksum());
}
// Save the file
@@ -1441,7 +1458,7 @@
EXPECT_EQ(2, FPDFPage_CountObjects(saved_page));
{
ScopedFPDFBitmap page_bitmap = RenderPage(saved_page);
- CompareBitmap(page_bitmap.get(), 200, 200, kHelloWorldChecksum);
+ CompareBitmap(page_bitmap.get(), 200, 200, HelloWorldChecksum());
}
CloseSavedPage(saved_page);
@@ -1667,7 +1684,7 @@
{
ScopedFPDFBitmap page_bitmap = RenderPage(page);
- CompareBitmap(page_bitmap.get(), 200, 200, kFirstRemovedChecksum);
+ CompareBitmap(page_bitmap.get(), 200, 200, FirstRemovedChecksum());
}
// Save the file
@@ -1686,7 +1703,7 @@
ASSERT_EQ(0, cpdf_page_object->GetContentStream());
{
ScopedFPDFBitmap page_bitmap = RenderPage(saved_page);
- CompareBitmap(page_bitmap.get(), 200, 200, kFirstRemovedChecksum);
+ CompareBitmap(page_bitmap.get(), 200, 200, FirstRemovedChecksum());
}
CloseSavedPage(saved_page);
@@ -1727,10 +1744,10 @@
cpdf_page_object = CPDFPageObjectFromFPDFPageObject(page_object);
ASSERT_EQ(0, cpdf_page_object->GetContentStream());
- using pdfium::kHelloWorldRemovedChecksum;
+ using pdfium::HelloWorldRemovedChecksum;
{
ScopedFPDFBitmap page_bitmap = RenderPage(page);
- CompareBitmap(page_bitmap.get(), 200, 200, kHelloWorldRemovedChecksum);
+ CompareBitmap(page_bitmap.get(), 200, 200, HelloWorldRemovedChecksum());
}
// Save the file
@@ -1749,7 +1766,7 @@
ASSERT_EQ(0, cpdf_page_object->GetContentStream());
{
ScopedFPDFBitmap page_bitmap = RenderPage(saved_page);
- CompareBitmap(page_bitmap.get(), 200, 200, kHelloWorldRemovedChecksum);
+ CompareBitmap(page_bitmap.get(), 200, 200, HelloWorldRemovedChecksum());
}
CloseSavedPage(saved_page);
@@ -1880,10 +1897,10 @@
FPDF_PAGE page = LoadPage(0);
ASSERT_TRUE(page);
- using pdfium::kManyRectanglesChecksum;
+ using pdfium::ManyRectanglesChecksum;
{
ScopedFPDFBitmap page_bitmap = RenderPage(page);
- CompareBitmap(page_bitmap.get(), 200, 300, kManyRectanglesChecksum);
+ CompareBitmap(page_bitmap.get(), 200, 300, ManyRectanglesChecksum());
}
// Add a black rectangle.
@@ -1927,7 +1944,7 @@
FPDFPageObj_Destroy(added_object);
{
ScopedFPDFBitmap page_bitmap = RenderPage(saved_page);
- CompareBitmap(page_bitmap.get(), 200, 300, kManyRectanglesChecksum);
+ CompareBitmap(page_bitmap.get(), 200, 300, ManyRectanglesChecksum());
}
EXPECT_EQ(kOriginalObjectCount, FPDFPage_CountObjects(saved_page));
@@ -1946,7 +1963,7 @@
EXPECT_EQ(kOriginalObjectCount, FPDFPage_CountObjects(saved_page));
{
ScopedFPDFBitmap page_bitmap = RenderPage(saved_page);
- CompareBitmap(page_bitmap.get(), 200, 300, kManyRectanglesChecksum);
+ CompareBitmap(page_bitmap.get(), 200, 300, ManyRectanglesChecksum());
}
CloseSavedPage(saved_page);
@@ -2216,10 +2233,10 @@
EXPECT_TRUE(FPDFPage_GenerateContent(page.get()));
{
ScopedFPDFBitmap page_bitmap = RenderPage(page.get());
- CompareBitmap(page_bitmap.get(), 612, 792, kBottomTextChecksum);
+ CompareBitmap(page_bitmap.get(), 612, 792, BottomTextChecksum());
EXPECT_TRUE(FPDF_SaveAsCopy(document(), this, 0));
- VerifySavedDocument(612, 792, kBottomTextChecksum);
+ VerifySavedDocument(612, 792, BottomTextChecksum());
}
// Try another font
@@ -2711,7 +2728,7 @@
FPDFPageObj_Transform(text_object, 1, 0, 0, 1, 20, 20);
FPDFPage_InsertObject(page.get(), text_object);
ScopedFPDFBitmap page_bitmap = RenderPage(page.get());
- CompareBitmap(page_bitmap.get(), 612, 792, kBottomTextChecksum);
+ CompareBitmap(page_bitmap.get(), 612, 792, BottomTextChecksum());
}
TEST_F(FPDFEditEmbedderTest, LoadStandardFonts) {
@@ -3052,7 +3069,7 @@
FPDFPageObj_Transform(text_object, 1, 0, 0, 1, 400, 400);
FPDFPage_InsertObject(page, text_object);
ScopedFPDFBitmap page_bitmap = RenderPage(page);
- CompareBitmap(page_bitmap.get(), 612, 792, kLoadedFontTextChecksum);
+ CompareBitmap(page_bitmap.get(), 612, 792, LoadedFontTextChecksum());
// Add some more text, same font
FPDF_PAGEOBJECT text_object2 =
@@ -3238,7 +3255,7 @@
// Render and check there are no marks.
{
ScopedFPDFBitmap page_bitmap = RenderPage(page);
- CompareBitmap(page_bitmap.get(), 200, 200, kHelloWorldChecksum);
+ CompareBitmap(page_bitmap.get(), 200, 200, HelloWorldChecksum());
}
CheckMarkCounts(page, 0, 2, 0, 0, 0, 0);
@@ -3252,7 +3269,7 @@
// Render and check there is 1 mark.
{
ScopedFPDFBitmap page_bitmap = RenderPage(page);
- CompareBitmap(page_bitmap.get(), 200, 200, kHelloWorldChecksum);
+ CompareBitmap(page_bitmap.get(), 200, 200, HelloWorldChecksum());
}
CheckMarkCounts(page, 0, 2, 0, 0, 0, 1);
@@ -3268,7 +3285,7 @@
{
ScopedFPDFBitmap page_bitmap = RenderPage(saved_page);
- CompareBitmap(page_bitmap.get(), 200, 200, kHelloWorldChecksum);
+ CompareBitmap(page_bitmap.get(), 200, 200, HelloWorldChecksum());
}
CheckMarkCounts(saved_page, 0, 2, 0, 0, 0, 1);
@@ -3420,7 +3437,7 @@
// Render and check the bitmap is the expected one.
{
ScopedFPDFBitmap page_bitmap = RenderPage(page);
- CompareBitmap(page_bitmap.get(), 612, 792, kLoadedFontTextChecksum);
+ CompareBitmap(page_bitmap.get(), 612, 792, LoadedFontTextChecksum());
}
// Now save the result.
diff --git a/fpdfsdk/fpdf_editpage_embeddertest.cpp b/fpdfsdk/fpdf_editpage_embeddertest.cpp
index fe2719b..2d59efa 100644
--- a/fpdfsdk/fpdf_editpage_embeddertest.cpp
+++ b/fpdfsdk/fpdf_editpage_embeddertest.cpp
@@ -30,7 +30,7 @@
EXPECT_EQ(300, page_height);
ScopedFPDFBitmap bitmap = RenderLoadedPage(page);
CompareBitmap(bitmap.get(), page_width, page_height,
- pdfium::kRectanglesChecksum);
+ pdfium::RectanglesChecksum());
}
FPDFPage_SetRotation(page, 1);
diff --git a/fpdfsdk/fpdf_formfill_embeddertest.cpp b/fpdfsdk/fpdf_formfill_embeddertest.cpp
index 320c34d..fb9f144 100644
--- a/fpdfsdk/fpdf_formfill_embeddertest.cpp
+++ b/fpdfsdk/fpdf_formfill_embeddertest.cpp
@@ -22,7 +22,7 @@
#include "third_party/base/check.h"
#include "third_party/base/check_op.h"
-using pdfium::kTextFormChecksum;
+using pdfium::TextFormChecksum;
using testing::_;
using testing::InSequence;
@@ -1344,7 +1344,7 @@
FPDF_PAGE page = LoadPage(0);
ASSERT_TRUE(page);
ScopedFPDFBitmap bitmap1 = RenderLoadedPage(page);
- CompareBitmap(bitmap1.get(), 300, 300, kTextFormChecksum);
+ CompareBitmap(bitmap1.get(), 300, 300, TextFormChecksum());
// Click on the textfield
EXPECT_EQ(FPDF_FORMFIELD_TEXTFIELD,
@@ -1399,7 +1399,7 @@
ASSERT_TRUE(page);
ScopedFPDFBitmap bitmap_normal = RenderLoadedPage(page);
- CompareBitmap(bitmap_normal.get(), 200, 200, pdfium::kBug890322Checksum);
+ CompareBitmap(bitmap_normal.get(), 200, 200, pdfium::Bug890322Checksum());
ScopedFPDFBitmap bitmap_reverse_byte_order =
RenderLoadedPageWithFlags(page, FPDF_REVERSE_BYTE_ORDER);
@@ -1542,7 +1542,7 @@
FPDF_PAGE page = LoadPage(0);
ASSERT_TRUE(page);
ScopedFPDFBitmap bitmap1 = RenderLoadedPage(page);
- CompareBitmap(bitmap1.get(), 300, 300, kTextFormChecksum);
+ CompareBitmap(bitmap1.get(), 300, 300, TextFormChecksum());
// Removing the highlight changes the rendering.
FPDF_RemoveFormFieldHighlight(form_handle());
@@ -1552,7 +1552,7 @@
// Restoring it gives the original rendering.
SetInitialFormFieldHighlight(form_handle());
ScopedFPDFBitmap bitmap3 = RenderLoadedPage(page);
- CompareBitmap(bitmap3.get(), 300, 300, kTextFormChecksum);
+ CompareBitmap(bitmap3.get(), 300, 300, TextFormChecksum());
UnloadPage(page);
}
diff --git a/fpdfsdk/fpdf_ppo_embeddertest.cpp b/fpdfsdk/fpdf_ppo_embeddertest.cpp
index 6ee78d9..186b597 100644
--- a/fpdfsdk/fpdf_ppo_embeddertest.cpp
+++ b/fpdfsdk/fpdf_ppo_embeddertest.cpp
@@ -26,6 +26,39 @@
return size;
}
+constexpr int kRectanglesMultiPagesPageCount = 2;
+
+const char* RectanglesMultiPagesExpectedMD5s(int page_index) {
+#if defined(_SKIA_SUPPORT_) || defined(_SKIA_SUPPORT_PATHS_)
+ static constexpr const char*
+ kRectanglesMultiPagesExpectedMD5s[kRectanglesMultiPagesPageCount] = {
+ "7a4cddd5a17a60ce50acb53e318d94f8",
+ "4fa6a7507e9f3ef4f28719a7d656c3a5"};
+#else
+ static constexpr const char*
+ kRectanglesMultiPagesExpectedMD5s[kRectanglesMultiPagesPageCount] = {
+ "72d0d7a19a2f40e010ca6a1133b33e1e",
+ "fb18142190d770cfbc329d2b071aee4d"};
+#endif
+
+ return kRectanglesMultiPagesExpectedMD5s[page_index];
+}
+
+const char* Bug750568PageHash(int page_index) {
+ constexpr int kBug750568PageCount = 4;
+#if defined(_SKIA_SUPPORT_) || defined(_SKIA_SUPPORT_PATHS_)
+ static constexpr const char* kBug750568PageHashes[kBug750568PageCount] = {
+ "eaa139e944eafb43d31e8742a0e158de", "226485e9d4fa6a67dfe0a88723f12060",
+ "c5601a3492ae5dcc5dd25140fc463bfe", "1f60055b54de4fac8a59c65e90da156e"};
+#else
+ static constexpr const char* kBug750568PageHashes[kBug750568PageCount] = {
+ "64ad08132a1c5a166768298c8a578f57", "83b83e2f6bc80707d0a917c7634140b9",
+ "913cd3723a451e4e46fbc2c05702d1ee", "81fb7cfd4860f855eb468f73dfeb6d60"};
+#endif
+
+ return kBug750568PageHashes[page_index];
+}
+
} // namespace
TEST_F(FPDFPPOEmbedderTest, NoViewerPreferences) {
@@ -122,25 +155,18 @@
// FPDF_ImportNPagesToOne()
TEST_F(FPDFPPOEmbedderTest, NupRenderImage) {
ASSERT_TRUE(OpenDocument("rectangles_multi_pages.pdf"));
- const int kPageCount = 2;
-#if defined(_SKIA_SUPPORT_) || defined(_SKIA_SUPPORT_PATHS_)
- static constexpr const char* kExpectedMD5s[kPageCount] = {
- "7a4cddd5a17a60ce50acb53e318d94f8", "4fa6a7507e9f3ef4f28719a7d656c3a5"};
-#else
- static constexpr const char* kExpectedMD5s[kPageCount] = {
- "72d0d7a19a2f40e010ca6a1133b33e1e", "fb18142190d770cfbc329d2b071aee4d"};
-#endif
ScopedFPDFDocument output_doc_3up(
FPDF_ImportNPagesToOne(document(), 792, 612, 3, 1));
ASSERT_TRUE(output_doc_3up);
- ASSERT_EQ(kPageCount, FPDF_GetPageCount(output_doc_3up.get()));
- for (int i = 0; i < kPageCount; ++i) {
+ ASSERT_EQ(kRectanglesMultiPagesPageCount,
+ FPDF_GetPageCount(output_doc_3up.get()));
+ for (int i = 0; i < kRectanglesMultiPagesPageCount; ++i) {
ScopedFPDFPage page(FPDF_LoadPage(output_doc_3up.get(), i));
ASSERT_TRUE(page);
ScopedFPDFBitmap bitmap = RenderPage(page.get());
EXPECT_EQ(792, FPDFBitmap_GetWidth(bitmap.get()));
EXPECT_EQ(612, FPDFBitmap_GetHeight(bitmap.get()));
- EXPECT_EQ(kExpectedMD5s[i], HashBitmap(bitmap.get()));
+ EXPECT_EQ(RectanglesMultiPagesExpectedMD5s(i), HashBitmap(bitmap.get()));
}
}
@@ -239,7 +265,7 @@
{
ScopedFPDFBitmap bitmap = RenderLoadedPage(page);
- CompareBitmap(bitmap.get(), 200, 300, pdfium::kRectanglesChecksum);
+ CompareBitmap(bitmap.get(), 200, 300, pdfium::RectanglesChecksum());
}
FPDF_PAGEOBJECT page_object = FPDF_NewFormObjectFromXObject(xobject);
@@ -255,7 +281,7 @@
{
// TODO(thestig): This should have `kChecksum`.
ScopedFPDFBitmap bitmap = RenderLoadedPage(page);
- CompareBitmap(bitmap.get(), 200, 300, pdfium::kRectanglesChecksum);
+ CompareBitmap(bitmap.get(), 200, 300, pdfium::RectanglesChecksum());
}
FPDF_CloseXObject(xobject);
@@ -490,16 +516,6 @@
}
TEST_F(FPDFPPOEmbedderTest, BUG_750568) {
-#if defined(_SKIA_SUPPORT_) || defined(_SKIA_SUPPORT_PATHS_)
- const char* const kHashes[] = {
- "eaa139e944eafb43d31e8742a0e158de", "226485e9d4fa6a67dfe0a88723f12060",
- "c5601a3492ae5dcc5dd25140fc463bfe", "1f60055b54de4fac8a59c65e90da156e"};
-#else
- const char* const kHashes[] = {
- "64ad08132a1c5a166768298c8a578f57", "83b83e2f6bc80707d0a917c7634140b9",
- "913cd3723a451e4e46fbc2c05702d1ee", "81fb7cfd4860f855eb468f73dfeb6d60"};
-#endif
-
ASSERT_TRUE(OpenDocument("bug_750568.pdf"));
ASSERT_EQ(4, FPDF_GetPageCount(document()));
@@ -508,7 +524,7 @@
ASSERT_TRUE(page);
ScopedFPDFBitmap bitmap = RenderLoadedPage(page);
- CompareBitmap(bitmap.get(), 200, 200, kHashes[i]);
+ CompareBitmap(bitmap.get(), 200, 200, Bug750568PageHash(i));
UnloadPage(page);
}
@@ -524,7 +540,7 @@
ASSERT_TRUE(page);
ScopedFPDFBitmap bitmap = RenderPage(page);
- CompareBitmap(bitmap.get(), 200, 200, kHashes[i]);
+ CompareBitmap(bitmap.get(), 200, 200, Bug750568PageHash(i));
FPDF_ClosePage(page);
}
FPDF_CloseDocument(output_doc);
@@ -536,7 +552,7 @@
ASSERT_TRUE(page);
ScopedFPDFBitmap bitmap = RenderLoadedPage(page);
- CompareBitmap(bitmap.get(), 200, 200, pdfium::kHelloWorldChecksum);
+ CompareBitmap(bitmap.get(), 200, 200, pdfium::HelloWorldChecksum());
UnloadPage(page);
ScopedFPDFDocument new_doc(FPDF_CreateNewDocument());
@@ -550,5 +566,5 @@
ScopedFPDFPage new_page(FPDF_LoadPage(new_doc.get(), 0));
ASSERT_TRUE(new_page);
ScopedFPDFBitmap new_bitmap = RenderPage(new_page.get());
- CompareBitmap(new_bitmap.get(), 200, 200, pdfium::kHelloWorldChecksum);
+ CompareBitmap(new_bitmap.get(), 200, 200, pdfium::HelloWorldChecksum());
}
diff --git a/fpdfsdk/fpdf_transformpage_embeddertest.cpp b/fpdfsdk/fpdf_transformpage_embeddertest.cpp
index 925e0b5..bf69292 100644
--- a/fpdfsdk/fpdf_transformpage_embeddertest.cpp
+++ b/fpdfsdk/fpdf_transformpage_embeddertest.cpp
@@ -12,16 +12,20 @@
#include "third_party/base/test/scoped_locale.h"
#endif
-using pdfium::kRectanglesChecksum;
+using pdfium::RectanglesChecksum;
namespace {
+const char* ShrunkMD5() {
#if defined(_SKIA_SUPPORT_) || defined(_SKIA_SUPPORT_PATHS_)
-constexpr char kShrunkMD5[] = "78c52d6029283090036e6db6683401e2";
+ static constexpr char kShrunkMD5[] = "78c52d6029283090036e6db6683401e2";
#else
-constexpr char kShrunkMD5[] = "f4136cc9209207ab60eb8381a3df2e69";
+ static constexpr char kShrunkMD5[] = "f4136cc9209207ab60eb8381a3df2e69";
#endif
+ return kShrunkMD5;
+}
+
} // namespace
class FPDFTransformEmbedderTest : public EmbedderTest {};
@@ -228,7 +232,8 @@
EXPECT_EQ(200, page_width);
EXPECT_EQ(300, page_height);
ScopedFPDFBitmap bitmap = RenderLoadedPage(page);
- CompareBitmap(bitmap.get(), page_width, page_height, kRectanglesChecksum);
+ CompareBitmap(bitmap.get(), page_width, page_height,
+ RectanglesChecksum());
}
FPDFPage_SetCropBox(page, 10, 20, 100, 150);
@@ -304,7 +309,8 @@
EXPECT_EQ(200, page_width);
EXPECT_EQ(300, page_height);
ScopedFPDFBitmap bitmap = RenderLoadedPage(page);
- CompareBitmap(bitmap.get(), page_width, page_height, kRectanglesChecksum);
+ CompareBitmap(bitmap.get(), page_width, page_height,
+ RectanglesChecksum());
}
FPDFPage_SetMediaBox(page, 20, 30, 100, 150);
@@ -432,7 +438,8 @@
EXPECT_EQ(200, page_width);
EXPECT_EQ(300, page_height);
ScopedFPDFBitmap bitmap = RenderLoadedPage(page);
- CompareBitmap(bitmap.get(), page_width, page_height, kRectanglesChecksum);
+ CompareBitmap(bitmap.get(), page_width, page_height,
+ RectanglesChecksum());
}
{
@@ -447,7 +454,8 @@
EXPECT_EQ(200, page_width);
EXPECT_EQ(300, page_height);
ScopedFPDFBitmap bitmap = RenderLoadedPage(page);
- CompareBitmap(bitmap.get(), page_width, page_height, kRectanglesChecksum);
+ CompareBitmap(bitmap.get(), page_width, page_height,
+ RectanglesChecksum());
}
UnloadPage(page);
@@ -466,7 +474,7 @@
EXPECT_EQ(200, page_width);
EXPECT_EQ(300, page_height);
ScopedFPDFBitmap bitmap = RenderSavedPage(saved_page);
- CompareBitmap(bitmap.get(), page_width, page_height, kShrunkMD5);
+ CompareBitmap(bitmap.get(), page_width, page_height, ShrunkMD5());
CloseSavedPage(saved_page);
CloseSavedDocument();
@@ -489,7 +497,8 @@
EXPECT_EQ(200, page_width);
EXPECT_EQ(300, page_height);
ScopedFPDFBitmap bitmap = RenderLoadedPage(page);
- CompareBitmap(bitmap.get(), page_width, page_height, kRectanglesChecksum);
+ CompareBitmap(bitmap.get(), page_width, page_height,
+ RectanglesChecksum());
}
{
@@ -504,7 +513,8 @@
EXPECT_EQ(200, page_width);
EXPECT_EQ(300, page_height);
ScopedFPDFBitmap bitmap = RenderLoadedPage(page);
- CompareBitmap(bitmap.get(), page_width, page_height, kRectanglesChecksum);
+ CompareBitmap(bitmap.get(), page_width, page_height,
+ RectanglesChecksum());
}
UnloadPage(page);
@@ -523,7 +533,7 @@
EXPECT_EQ(200, page_width);
EXPECT_EQ(300, page_height);
ScopedFPDFBitmap bitmap = RenderSavedPage(saved_page);
- CompareBitmap(bitmap.get(), page_width, page_height, kShrunkMD5);
+ CompareBitmap(bitmap.get(), page_width, page_height, ShrunkMD5());
CloseSavedPage(saved_page);
CloseSavedDocument();
diff --git a/fpdfsdk/fpdf_view_embeddertest.cpp b/fpdfsdk/fpdf_view_embeddertest.cpp
index 5a1ae31..aba32c2 100644
--- a/fpdfsdk/fpdf_view_embeddertest.cpp
+++ b/fpdfsdk/fpdf_view_embeddertest.cpp
@@ -25,7 +25,7 @@
#include "testing/utils/path_service.h"
#include "third_party/base/check.h"
-using pdfium::kManyRectanglesChecksum;
+using pdfium::ManyRectanglesChecksum;
namespace {
@@ -946,9 +946,9 @@
EXPECT_FLOAT_EQ(200, page_width);
EXPECT_FLOAT_EQ(300, page_height);
- using pdfium::kRectanglesChecksum;
+ using pdfium::RectanglesChecksum;
ScopedFPDFBitmap bitmap = RenderLoadedPage(page);
- CompareBitmap(bitmap.get(), page_width, page_height, kRectanglesChecksum);
+ CompareBitmap(bitmap.get(), page_width, page_height, RectanglesChecksum());
FS_RECTF page_rect{0, 0, page_width, page_height};
@@ -956,7 +956,7 @@
// the RenderLoadedPage() output.
FS_MATRIX identity_matrix{1, 0, 0, 1, 0, 0};
TestRenderPageBitmapWithMatrix(page, page_width, page_height, identity_matrix,
- page_rect, kRectanglesChecksum);
+ page_rect, RectanglesChecksum());
// Again render with an identity matrix but with a smaller clipping rect.
FS_RECTF middle_of_page_rect{page_width / 4, page_height / 4,
@@ -1400,21 +1400,21 @@
FPDF_PAGE page = LoadPage(0);
ASSERT_TRUE(page);
- TestRenderPageBitmapWithFlags(page, 0, kManyRectanglesChecksum);
- TestRenderPageBitmapWithFlags(page, FPDF_ANNOT, kManyRectanglesChecksum);
- TestRenderPageBitmapWithFlags(page, FPDF_LCD_TEXT, kManyRectanglesChecksum);
+ TestRenderPageBitmapWithFlags(page, 0, ManyRectanglesChecksum());
+ TestRenderPageBitmapWithFlags(page, FPDF_ANNOT, ManyRectanglesChecksum());
+ TestRenderPageBitmapWithFlags(page, FPDF_LCD_TEXT, ManyRectanglesChecksum());
TestRenderPageBitmapWithFlags(page, FPDF_NO_NATIVETEXT,
- kManyRectanglesChecksum);
+ ManyRectanglesChecksum());
TestRenderPageBitmapWithFlags(page, FPDF_GRAYSCALE, kGrayscaleMD5);
TestRenderPageBitmapWithFlags(page, FPDF_RENDER_LIMITEDIMAGECACHE,
- kManyRectanglesChecksum);
+ ManyRectanglesChecksum());
TestRenderPageBitmapWithFlags(page, FPDF_RENDER_FORCEHALFTONE,
- kManyRectanglesChecksum);
- TestRenderPageBitmapWithFlags(page, FPDF_PRINTING, kManyRectanglesChecksum);
+ ManyRectanglesChecksum());
+ TestRenderPageBitmapWithFlags(page, FPDF_PRINTING, ManyRectanglesChecksum());
TestRenderPageBitmapWithFlags(page, FPDF_RENDER_NO_SMOOTHTEXT,
- kManyRectanglesChecksum);
+ ManyRectanglesChecksum());
TestRenderPageBitmapWithFlags(page, FPDF_RENDER_NO_SMOOTHIMAGE,
- kManyRectanglesChecksum);
+ ManyRectanglesChecksum());
TestRenderPageBitmapWithFlags(page, FPDF_RENDER_NO_SMOOTHPATH,
kNoSmoothpathMD5);
@@ -1454,22 +1454,22 @@
static constexpr int kBgrxStride = 800; // Width of 200 * 32 bits per pixel.
TestRenderPageBitmapWithInternalMemory(page, FPDFBitmap_BGRx,
- kManyRectanglesChecksum);
+ ManyRectanglesChecksum());
TestRenderPageBitmapWithInternalMemoryAndStride(
- page, FPDFBitmap_BGRx, kBgrxStride, kManyRectanglesChecksum);
+ page, FPDFBitmap_BGRx, kBgrxStride, ManyRectanglesChecksum());
TestRenderPageBitmapWithExternalMemory(page, FPDFBitmap_BGRx,
- kManyRectanglesChecksum);
+ ManyRectanglesChecksum());
TestRenderPageBitmapWithExternalMemoryAndNoStride(page, FPDFBitmap_BGRx,
- kManyRectanglesChecksum);
+ ManyRectanglesChecksum());
TestRenderPageBitmapWithInternalMemory(page, FPDFBitmap_BGRA,
- kManyRectanglesChecksum);
+ ManyRectanglesChecksum());
TestRenderPageBitmapWithInternalMemoryAndStride(
- page, FPDFBitmap_BGRA, kBgrxStride, kManyRectanglesChecksum);
+ page, FPDFBitmap_BGRA, kBgrxStride, ManyRectanglesChecksum());
TestRenderPageBitmapWithExternalMemory(page, FPDFBitmap_BGRA,
- kManyRectanglesChecksum);
+ ManyRectanglesChecksum());
TestRenderPageBitmapWithExternalMemoryAndNoStride(page, FPDFBitmap_BGRA,
- kManyRectanglesChecksum);
+ ManyRectanglesChecksum());
UnloadPage(page);
}
@@ -1479,19 +1479,19 @@
FPDF_PAGE page = LoadPage(0);
ASSERT_TRUE(page);
- using pdfium::kHelloWorldChecksum;
- TestRenderPageBitmapWithFlags(page, 0, kHelloWorldChecksum);
- TestRenderPageBitmapWithFlags(page, FPDF_ANNOT, kHelloWorldChecksum);
- TestRenderPageBitmapWithFlags(page, FPDF_GRAYSCALE, kHelloWorldChecksum);
+ using pdfium::HelloWorldChecksum;
+ TestRenderPageBitmapWithFlags(page, 0, HelloWorldChecksum());
+ TestRenderPageBitmapWithFlags(page, FPDF_ANNOT, HelloWorldChecksum());
+ TestRenderPageBitmapWithFlags(page, FPDF_GRAYSCALE, HelloWorldChecksum());
TestRenderPageBitmapWithFlags(page, FPDF_RENDER_LIMITEDIMAGECACHE,
- kHelloWorldChecksum);
+ HelloWorldChecksum());
TestRenderPageBitmapWithFlags(page, FPDF_RENDER_FORCEHALFTONE,
- kHelloWorldChecksum);
- TestRenderPageBitmapWithFlags(page, FPDF_PRINTING, kHelloWorldChecksum);
+ HelloWorldChecksum());
+ TestRenderPageBitmapWithFlags(page, FPDF_PRINTING, HelloWorldChecksum());
TestRenderPageBitmapWithFlags(page, FPDF_RENDER_NO_SMOOTHIMAGE,
- kHelloWorldChecksum);
+ HelloWorldChecksum());
TestRenderPageBitmapWithFlags(page, FPDF_RENDER_NO_SMOOTHPATH,
- kHelloWorldChecksum);
+ HelloWorldChecksum());
#if defined(_SKIA_SUPPORT_)
static const char kLcdTextChecksum[] = "c1c548442e0e0f949c5550d89bf8ae3b";
diff --git a/testing/embedder_test_constants.cpp b/testing/embedder_test_constants.cpp
index b0fc3ac..62f5337 100644
--- a/testing/embedder_test_constants.cpp
+++ b/testing/embedder_test_constants.cpp
@@ -8,53 +8,98 @@
namespace pdfium {
+const char* AnnotationStampWithApChecksum() {
#if defined(_SKIA_SUPPORT_) || defined(_SKIA_SUPPORT_PATHS_)
-const char kAnnotationStampWithApChecksum[] =
- "a31381406d0b95049e418720750b78dd";
+ static constexpr char kAnnotationStampWithApChecksum[] =
+ "a31381406d0b95049e418720750b78dd";
#elif BUILDFLAG(IS_APPLE)
-const char kAnnotationStampWithApChecksum[] =
- "d243b5d64752be0f45b86df7bd2e2708";
+ static constexpr char kAnnotationStampWithApChecksum[] =
+ "d243b5d64752be0f45b86df7bd2e2708";
#else
-const char kAnnotationStampWithApChecksum[] =
- "cdde6c161679ab10b07c38c1ef04b7e8";
+ static constexpr char kAnnotationStampWithApChecksum[] =
+ "cdde6c161679ab10b07c38c1ef04b7e8";
#endif
+ return kAnnotationStampWithApChecksum;
+}
+
const char kBlankPage612By792Checksum[] = "1940568c9ba33bac5d0b1ee9558c76b3";
+const char* Bug890322Checksum() {
#if defined(_SKIA_SUPPORT_) || defined(_SKIA_SUPPORT_PATHS_)
-const char kBug890322Checksum[] = "793689536cf64fe792c2f241888c0cf3";
+ static constexpr char kBug890322Checksum[] =
+ "793689536cf64fe792c2f241888c0cf3";
#else
-const char kBug890322Checksum[] = "6c674642154408e877d88c6c082d67e9";
+ static constexpr char kBug890322Checksum[] =
+ "6c674642154408e877d88c6c082d67e9";
#endif
+ return kBug890322Checksum;
+}
+
+const char* HelloWorldChecksum() {
#if BUILDFLAG(IS_APPLE) && !defined(_SKIA_SUPPORT_) && \
!defined(_SKIA_SUPPORT_PATHS_)
-const char kHelloWorldChecksum[] = "6eef7237f7591f07616e238422086737";
+ static constexpr char kHelloWorldChecksum[] =
+ "6eef7237f7591f07616e238422086737";
#else
-const char kHelloWorldChecksum[] = "c1c548442e0e0f949c5550d89bf8ae3b";
+ static constexpr char kHelloWorldChecksum[] =
+ "c1c548442e0e0f949c5550d89bf8ae3b";
#endif
+ return kHelloWorldChecksum;
+}
+
+const char* HelloWorldRemovedChecksum() {
#if BUILDFLAG(IS_APPLE) && !defined(_SKIA_SUPPORT_) && \
!defined(_SKIA_SUPPORT_PATHS_)
-const char kHelloWorldRemovedChecksum[] = "6e1cae48a2e35c521dee4ca502f48af6";
+ static constexpr char kHelloWorldRemovedChecksum[] =
+ "6e1cae48a2e35c521dee4ca502f48af6";
#else
-const char kHelloWorldRemovedChecksum[] = "4a9b80f675f7f3bf2da1b02f12449e4b";
+ static constexpr char kHelloWorldRemovedChecksum[] =
+ "4a9b80f675f7f3bf2da1b02f12449e4b";
#endif
+ return kHelloWorldRemovedChecksum;
+}
+
+const char* ManyRectanglesChecksum() {
#if defined(_SKIA_SUPPORT_) || defined(_SKIA_SUPPORT_PATHS_)
-const char kManyRectanglesChecksum[] = "4e7e280c1597222afcb0ee3bb90ec119";
-const char kRectanglesChecksum[] = "b4e411a6b5ffa59a50efede2efece597";
+ static constexpr char kManyRectanglesChecksum[] =
+ "4e7e280c1597222afcb0ee3bb90ec119";
#else
-const char kManyRectanglesChecksum[] = "b0170c575b65ecb93ebafada0ff0f038";
-const char kRectanglesChecksum[] = "0a90de37f52127619c3dfb642b5fa2fe";
+ static constexpr char kManyRectanglesChecksum[] =
+ "b0170c575b65ecb93ebafada0ff0f038";
#endif
+ return kManyRectanglesChecksum;
+}
+
+const char* RectanglesChecksum() {
#if defined(_SKIA_SUPPORT_) || defined(_SKIA_SUPPORT_PATHS_)
-const char kTextFormChecksum[] = "e6d2eb75f18d773f0dad938b1bb22e23";
+ static constexpr char kRectanglesChecksum[] =
+ "b4e411a6b5ffa59a50efede2efece597";
+#else
+ static constexpr char kRectanglesChecksum[] =
+ "0a90de37f52127619c3dfb642b5fa2fe";
+#endif
+
+ return kRectanglesChecksum;
+}
+
+const char* TextFormChecksum() {
+#if defined(_SKIA_SUPPORT_) || defined(_SKIA_SUPPORT_PATHS_)
+ static constexpr char kTextFormChecksum[] =
+ "e6d2eb75f18d773f0dad938b1bb22e23";
#elif BUILDFLAG(IS_APPLE)
-const char kTextFormChecksum[] = "fa2bf756942a950101fc147fc4ef3f82";
+ static constexpr char kTextFormChecksum[] =
+ "fa2bf756942a950101fc147fc4ef3f82";
#else
-const char kTextFormChecksum[] = "6f86fe1dbed5965d91aec6e0b829e29f";
+ static constexpr char kTextFormChecksum[] =
+ "6f86fe1dbed5965d91aec6e0b829e29f";
#endif
+ return kTextFormChecksum;
+}
+
} // namespace pdfium
diff --git a/testing/embedder_test_constants.h b/testing/embedder_test_constants.h
index 41fe790..3922944 100644
--- a/testing/embedder_test_constants.h
+++ b/testing/embedder_test_constants.h
@@ -8,28 +8,28 @@
namespace pdfium {
// MD5 hash for rendering annotation_stamp_with_ap.pdf with annotations.
-extern const char kAnnotationStampWithApChecksum[];
+const char* AnnotationStampWithApChecksum();
// MD5 hash for rendering a 612x792 blank page.
extern const char kBlankPage612By792Checksum[];
// MD5 hash for rendering bug_890322.pdf.
-extern const char kBug890322Checksum[];
+const char* Bug890322Checksum();
// MD5 hash for rendering hello_world.pdf or bug_455199.pdf.
-extern const char kHelloWorldChecksum[];
+const char* HelloWorldChecksum();
// MD5 hash for rendering hello_world.pdf after removing "Goodbye, world!".
-extern const char kHelloWorldRemovedChecksum[];
+const char* HelloWorldRemovedChecksum();
// MD5 hash for rendering many_rectangles.pdf.
-extern const char kManyRectanglesChecksum[];
+const char* ManyRectanglesChecksum();
// MD5 hash for rendering rectangles.pdf.
-extern const char kRectanglesChecksum[];
+const char* RectanglesChecksum();
// MD5 hash for rendering text_form.pdf.
-extern const char kTextFormChecksum[];
+const char* TextFormChecksum();
} // namespace pdfium
