commit 07e34860d4da3bcaca242103131c90c51901033a
author Lei Zhang <thestig@chromium.org> Tue Jul 02 19:05:37 2024 +0000
committer Pdfium LUCI CQ <pdfium-scoped@luci-project-accounts.iam.gserviceaccount.com> Tue Jul 02 19:05:37 2024 +0000
tree 8892c72b4ce41b592594c64c0706c0d5e12aea1c
parent 0424f3bb823c8686bac9c03b0fcd14d91d6824f3

Add unified "goldctl_version" git_revision tag

Use a single version number that describes goldctl on all 4 platforms.
Then there only needs to be 1 autoroller that updates this version
number, instead of 4 separate autoroller for the different platforms
that use individual package instance IDs.

The newly added goldctl_version value is equivalent to the instance IDs
it replaces. So the actual goldctl package in use stays the same.

Remove the last TODO for this bug, as there is no more work to be done
here. The rest is up to the infra team.

Bug: 42270656
Change-Id: Id7744350487a11fdffa0b68ca47d97470b584194
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/121410
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Tom Sepez <tsepez@google.com>
Commit-Queue: Lei Zhang <thestig@chromium.org>

DEPS

diff --git a/DEPS b/DEPS
index 7e1ac50..6832fc9 100644
--- a/DEPS
+++ b/DEPS
@@ -114,6 +114,10 @@
   # and whatever else without interference from each other.
   'gn_version': 'git_revision:b2afae122eeb6ce09c52d63f67dc53fc517dbdc8',
   # Three lines of non-changing comments so that
+  # the commit queue can handle CLs rolling goldctl CIPD package version
+  # and whatever else without interference from each other.
+  'goldctl_version': 'git_revision:46a1e3bbf2a0c3f2553b80e09430ea22d9d37911',
+  # Three lines of non-changing comments so that
   # the commit queue can handle CLs rolling gtest
   # and whatever else without interference from each other.
   'gtest_revision': '1d17ea141d2c11b8917d2c7d029f1c4e2b9769b2',
@@ -520,12 +524,11 @@
     'condition': 'checkout_rust',
   },
 
-  # TODO(crbug.com/pdfium/1650): Set up autorollers for goldctl.
   'tools/skia_goldctl/linux': {
     'packages': [
       {
         'package': 'skia/tools/goldctl/linux-amd64',
-        'version': 'LDPByLYqasHSy5ZxdGy0llSDaUnwdxFfx6L2NvZjxhwC',
+        'version': Var('goldctl_version'),
       }
     ],
     'dep_type': 'cipd',
@@ -536,7 +539,7 @@
     'packages': [
       {
         'package': 'skia/tools/goldctl/mac-amd64',
-        'version': 'Ri84uKWwD6OsP-lJpo7z2X68GibM6ynfZZaSXer2GoYC',
+        'version': Var('goldctl_version'),
       }
     ],
     'dep_type': 'cipd',
@@ -547,7 +550,7 @@
     'packages': [
       {
         'package': 'skia/tools/goldctl/mac-arm64',
-        'version': '8Yalv78nDvaIEFLlX-HbY-a-QueK4PQzFMEEhzt0bZQC',
+        'version': Var('goldctl_version'),
       }
     ],
     'dep_type': 'cipd',
@@ -558,7 +561,7 @@
     'packages': [
       {
         'package': 'skia/tools/goldctl/windows-amd64',
-        'version': 'KhS-PwKl3anmwJCxKIGQYybgN0loA5nw8vVRglJNhngC',
+        'version': Var('goldctl_version'),
       }
     ],
     'dep_type': 'cipd',