commit 08c40719f264aa1ac2266e0ba71da0350ca0f47b
author Hui Yingst <nigi@chromium.org> Wed Apr 29 01:37:35 2020 +0000
committer Chromium commit bot <commit-bot@chromium.org> Wed Apr 29 01:37:35 2020 +0000
tree 76bdebb79ea9118bd98732a4eb4da97270642d0e
parent 8a4d325489e1ee067b355c0b647f52b5c8158d07

Add Skia expected hash values for PDFium embedder tests.

Skia uses different font face rendering methods compared to AGG, which
leads to the text rendering discrepancy. This CL adds Skia expected
hash values for the embedder tests which use testing file
hello_world.pdf, and makes the following embedder tests pass for Skia:

- Enabled by this CL:
  FPDFEditEmbedderTest.RemovePageObject
  FPDFEditEmbedderTest.RemoveExistingPageObjectSplitStreamsLonely
  FPDFEditEmbedderTest.RemoveFirstFromSingleStream
  FPDFEditEmbedderTest.RemoveLastFromSingleStream

- Passed through updating hash values:
  CPDFSecurityHandlerEmbedderTest.*UTF8
  CPDFSecurityHandlerEmbedderTest.*Latin1

Bug: pdfium:1500
Change-Id: Ic6841b98575de38abbc56598a5b99ae710c22351
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/69110
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Hui Yingst <nigi@chromium.org>

testing/embedder_test_constants.cpp

diff --git a/testing/embedder_test_constants.cpp b/testing/embedder_test_constants.cpp
index 2c81dfd..e4d8534 100644
--- a/testing/embedder_test_constants.cpp
+++ b/testing/embedder_test_constants.cpp
@@ -16,16 +16,33 @@
 const char kBug890322Checksum[] = "6c674642154408e877d88c6c082d67e9";
 #endif
 
+#if defined(_SKIA_SUPPORT_) || defined(_SKIA_SUPPORT_PATHS_)
+#if defined(OS_WIN)
+const char kHelloWorldChecksum[] = "7fca5790ce81c715d74d955ea9939fd8";
+#else
+const char kHelloWorldChecksum[] = "66ecb880a880dd263ff495b28aeda0d1";
+#endif  // defined(OS_WIN)
+#else
 #if defined(OS_WIN)
 const char kHelloWorldChecksum[] = "795b7ce1626931aa06af0fa23b7d80bb";
-const char kHelloWorldRemovedChecksum[] = "93db13099042bafefb3c22a165bad684";
 #elif defined(OS_MACOSX)
 const char kHelloWorldChecksum[] = "c38b75e16a13852aee3b97d77a0f0ee7";
-const char kHelloWorldRemovedChecksum[] = "572b1022bb3e8f43dc671162fc62cf7f";
 #else
 const char kHelloWorldChecksum[] = "2baa4c0e1758deba1b9c908e1fbd04ed";
+#endif
+#endif  // defined(_SKIA_SUPPORT_) || defined(_SKIA_SUPPORT_PATHS_)
+
+#if defined(_SKIA_SUPPORT_) || defined(_SKIA_SUPPORT_PATHS_)
+const char kHelloWorldRemovedChecksum[] = "f87c63cbbc83fbb0f5b7b1d9e67448d0";
+#else
+#if defined(OS_WIN)
+const char kHelloWorldRemovedChecksum[] = "93db13099042bafefb3c22a165bad684";
+#elif defined(OS_MACOSX)
+const char kHelloWorldRemovedChecksum[] = "572b1022bb3e8f43dc671162fc62cf7f";
+#else
 const char kHelloWorldRemovedChecksum[] = "93dcc09055f87a2792c8e3065af99a1b";
 #endif
+#endif  // defined(_SKIA_SUPPORT_) || defined(_SKIA_SUPPORT_PATHS_)
 
 #if defined(_SKIA_SUPPORT_) || defined(_SKIA_SUPPORT_PATHS_)
 const char kManyRectanglesChecksum[] = "4e7e280c1597222afcb0ee3bb90ec119";