commit 09e030db27a1778fe502257985538aeb5fa67d00
author Lei Zhang <thestig@chromium.org> Thu May 04 18:31:37 2023 +0000
committer Pdfium LUCI CQ <pdfium-scoped@luci-project-accounts.iam.gserviceaccount.com> Thu May 04 18:31:37 2023 +0000
tree f0a51f8f557c1cd4715ef1ed95e70c31f6093035
parent 5afdf932325f59224a23774daf2b47d413cfcd31

Use more const pointers in CPDF_Image::FinishInitialization()

Avoid calling GetMutableFoo() methods, when GetFoo() works just as well.

Change-Id: I1f6f736d9573843a400b2faba55334dc902f7884
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/107031
Reviewed-by: K. Moon <kmoon@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>

core/fpdfapi/page/cpdf_image.cpp

diff --git a/core/fpdfapi/page/cpdf_image.cpp b/core/fpdfapi/page/cpdf_image.cpp
index c9be231..6b70819 100644
--- a/core/fpdfapi/page/cpdf_image.cpp
+++ b/core/fpdfapi/page/cpdf_image.cpp
@@ -66,8 +66,8 @@
 CPDF_Image::~CPDF_Image() = default;
 
 void CPDF_Image::FinishInitialization() {
-  RetainPtr<CPDF_Dictionary> pStreamDict = m_pStream->GetMutableDict();
-  m_pOC = pStreamDict->GetMutableDictFor("OC");
+  RetainPtr<const CPDF_Dictionary> pStreamDict = m_pStream->GetDict();
+  m_pOC = pStreamDict->GetDictFor("OC");
   m_bIsMask = !pStreamDict->KeyExist("ColorSpace") ||
               pStreamDict->GetBooleanFor("ImageMask", /*bDefault=*/false);
   m_bInterpolate = !!pStreamDict->GetIntegerFor("Interpolate");