commit 0a4a21363f4058b234cd0e28f17d71fee237affc
author Tom Sepez <tsepez@chromium.org> Tue Aug 16 22:59:14 2022 +0000
committer Pdfium LUCI CQ <pdfium-scoped@luci-project-accounts.iam.gserviceaccount.com> Tue Aug 16 22:59:14 2022 +0000
tree c6850fb70fac03ef05cddc9d256fd745bb8407c4
parent f7fa48c33f379c96908eebc178a793bd5ef73b6f

Mark JpegDecoder instance variables as private.

They are already treated as such by callers.

Bug: pdfium:1680
Change-Id: I45fcde2b2102c8c07268bf6024f11272b9468d9a
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/96592
Commit-Queue: Lei Zhang <thestig@chromium.org>
Auto-Submit: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>

core/fxcodec/jpeg/jpegmodule.cpp

diff --git a/core/fxcodec/jpeg/jpegmodule.cpp b/core/fxcodec/jpeg/jpegmodule.cpp
index fe2ee09..3585478 100644
--- a/core/fxcodec/jpeg/jpegmodule.cpp
+++ b/core/fxcodec/jpeg/jpegmodule.cpp
@@ -130,16 +130,6 @@
 
   bool InitDecode(bool bAcceptKnownBadHeader);
 
-  jmp_buf m_JmpBuf;
-  jpeg_decompress_struct m_Cinfo;
-  jpeg_error_mgr m_Jerr;
-  jpeg_source_mgr m_Src;
-  pdfium::span<const uint8_t> m_SrcSpan;
-  std::vector<uint8_t, FxAllocAllocator<uint8_t>> m_ScanlineBuf;
-  bool m_bInited = false;
-  bool m_bStarted = false;
-  bool m_bJpegTransform = false;
-
  private:
   void CalcPitch();
   void InitDecompressSrc();
@@ -163,6 +153,15 @@
   // be this many bytes before that.
   static constexpr size_t kSofMarkerByteOffset = 5;
 
+  jmp_buf m_JmpBuf;
+  jpeg_decompress_struct m_Cinfo;
+  jpeg_error_mgr m_Jerr;
+  jpeg_source_mgr m_Src;
+  pdfium::span<const uint8_t> m_SrcSpan;
+  std::vector<uint8_t, FxAllocAllocator<uint8_t>> m_ScanlineBuf;
+  bool m_bInited = false;
+  bool m_bStarted = false;
+  bool m_bJpegTransform = false;
   uint32_t m_nDefaultScaleDenom = 1;
 };