Forward declare ByteString in the custom gtest-printers.h
Since a forward declaration is sufficient, just use that and avoid
breaking the "all" target. Albeit the "all" target is not supported.
Bug: chromium:1447523
Change-Id: I7ca7b89c8aff3eb0d926e64088846a94b88d3415
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/107910
Reviewed-by: K. Moon <kmoon@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
diff --git a/core/fxcrt/BUILD.gn b/core/fxcrt/BUILD.gn
index d6e5e46..6bc74a4 100644
--- a/core/fxcrt/BUILD.gn
+++ b/core/fxcrt/BUILD.gn
@@ -134,7 +134,6 @@
"../../third_party:fx_lcms2",
"../../third_party:fx_libopenjpeg",
"../../third_party:fx_tiff",
- "../../third_party/googletest:gtest",
"../../xfa/*",
]
deps = [ "../../third_party:pdfium_base" ]
diff --git a/third_party/googletest/BUILD.gn b/third_party/googletest/BUILD.gn
index e2c3f6b..fb7b182 100644
--- a/third_party/googletest/BUILD.gn
+++ b/third_party/googletest/BUILD.gn
@@ -128,7 +128,6 @@
]
deps = []
- public_deps = [ "../../core/fxcrt" ]
if (is_fuchsia) {
deps += [
diff --git a/third_party/googletest/DEPS b/third_party/googletest/DEPS
deleted file mode 100644
index f80c171..0000000
--- a/third_party/googletest/DEPS
+++ /dev/null
@@ -1,3 +0,0 @@
-include_rules = [
- '+core/fxcrt',
-]
diff --git a/third_party/googletest/custom/gtest/internal/custom/gtest-printers.h b/third_party/googletest/custom/gtest/internal/custom/gtest-printers.h
index b2aebb3..523dc14 100644
--- a/third_party/googletest/custom/gtest/internal/custom/gtest-printers.h
+++ b/third_party/googletest/custom/gtest/internal/custom/gtest-printers.h
@@ -7,7 +7,9 @@
#include <string>
-#include "core/fxcrt/bytestring.h"
+namespace fxcrt {
+class ByteString;
+}
namespace testing {
