commit 0c83cf8c891ec0a92a996a5f32f0afd8dfa9775b
author Lei Zhang <thestig@chromium.org> Fri Sep 13 00:59:35 2024 +0000
committer Pdfium LUCI CQ <pdfium-scoped@luci-project-accounts.iam.gserviceaccount.com> Fri Sep 13 00:59:35 2024 +0000
tree 75a8c75a4c1416580013d04edcffd4e0d8e57343
parent 18240f769316d82061116807cd2215bdd0c216a6

Remove NOTREACHED_NORETURN() in CPDF_PSOP::GetFloatValue()

Use CHECK_EQ() instead.

Change-Id: Icf264d1f286104afaaacce364fa43f4a0f6b85b7
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/124330
Commit-Queue: Lei Zhang <thestig@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Tom Sepez <tsepez@google.com>

core/fpdfapi/page/cpdf_psengine.cpp

diff --git a/core/fpdfapi/page/cpdf_psengine.cpp b/core/fpdfapi/page/cpdf_psengine.cpp
index 75f3156..2918736 100644
--- a/core/fpdfapi/page/cpdf_psengine.cpp
+++ b/core/fpdfapi/page/cpdf_psengine.cpp
@@ -17,7 +17,6 @@
 #include "core/fxcrt/check_op.h"
 #include "core/fxcrt/fx_safe_types.h"
 #include "core/fxcrt/fx_string.h"
-#include "core/fxcrt/notreached.h"
 
 namespace {
 
@@ -107,10 +106,8 @@
 }
 
 float CPDF_PSOP::GetFloatValue() const {
-  if (m_op == PSOP_CONST)
-    return m_value;
-
-  NOTREACHED_NORETURN();
+  CHECK_EQ(m_op, PSOP_CONST);
+  return m_value;
 }
 
 bool CPDF_PSEngine::Execute() {