Google Git
Sign in
pdfium / pdfium / 0e744a2a712c01ca67cdd6161da561e2c6bc5925^! / . / core / fxcrt
commit0e744a2a712c01ca67cdd6161da561e2c6bc5925[log] [tgz]
authorLei Zhang <thestig@chromium.org>Tue Jun 02 00:44:28 2020 +0000
committerChromium commit bot <commit-bot@chromium.org>Tue Jun 02 00:44:28 2020 +0000
tree7b8157989f81e900e4394fcbf0fdab6643e87871
parentccb8ca6b8a54a2f2ecfc354e8f6deb06d7c95898 [diff]
Mass rewrite dtors to use "= default".

A simple search and replace with sed s/::~\(.*\) {}$/::~\1 = default;/
works surprisingly well.

Change-Id: Ie958265266e504006061e8f1b957046dfecd70dc
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/70251
Reviewed-by: Daniel Hosseinian <dhoss@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>

diff --git a/core/fxcrt/bytestring.cpp b/core/fxcrt/bytestring.cpp
index 0778bc2..7563db4 100644
--- a/core/fxcrt/bytestring.cpp
+++ b/core/fxcrt/bytestring.cpp

@@ -188,7 +188,7 @@
     m_pData.Reset(StringData::Create(str.c_str(), str.length()));
 }
 
-ByteString::~ByteString() {}
+ByteString::~ByteString() = default;
 
 ByteString& ByteString::operator=(const char* str) {
   if (!str || !str[0])

diff --git a/core/fxcrt/cfx_bitstream.cpp b/core/fxcrt/cfx_bitstream.cpp
index d16fc2f..66220ba 100644
--- a/core/fxcrt/cfx_bitstream.cpp
+++ b/core/fxcrt/cfx_bitstream.cpp

@@ -16,7 +16,7 @@
   ASSERT(pData.size() <= std::numeric_limits<uint32_t>::max() / 8);
 }
 
-CFX_BitStream::~CFX_BitStream() {}
+CFX_BitStream::~CFX_BitStream() = default;
 
 void CFX_BitStream::ByteAlign() {
   m_BitPos = FxAlignToBoundary<8>(m_BitPos);

diff --git a/core/fxcrt/css/cfx_csscolorvalue.cpp b/core/fxcrt/css/cfx_csscolorvalue.cpp
index 8c5473b..587ee5b 100644
--- a/core/fxcrt/css/cfx_csscolorvalue.cpp
+++ b/core/fxcrt/css/cfx_csscolorvalue.cpp

@@ -9,4 +9,4 @@
 CFX_CSSColorValue::CFX_CSSColorValue(FX_ARGB value)
     : CFX_CSSValue(CFX_CSSPrimitiveType::RGB), value_(value) {}
 
-CFX_CSSColorValue::~CFX_CSSColorValue() {}
+CFX_CSSColorValue::~CFX_CSSColorValue() = default;

diff --git a/core/fxcrt/css/cfx_csscomputedstyle.cpp b/core/fxcrt/css/cfx_csscomputedstyle.cpp
index 5b7b003..506305c 100644
--- a/core/fxcrt/css/cfx_csscomputedstyle.cpp
+++ b/core/fxcrt/css/cfx_csscomputedstyle.cpp

@@ -179,7 +179,7 @@
       m_eFontStyle(CFX_CSSFontStyle::Normal),
       m_eTextAlign(CFX_CSSTextAlign::Left) {}
 
-CFX_CSSComputedStyle::InheritedData::~InheritedData() {}
+CFX_CSSComputedStyle::InheritedData::~InheritedData() = default;
 
 CFX_CSSComputedStyle::NonInheritedData::NonInheritedData()
     : m_MarginWidth(CFX_CSSLengthUnit::Point, 0),

diff --git a/core/fxcrt/css/cfx_csscustomproperty.cpp b/core/fxcrt/css/cfx_csscustomproperty.cpp
index 353facd..c5c0730 100644
--- a/core/fxcrt/css/cfx_csscustomproperty.cpp
+++ b/core/fxcrt/css/cfx_csscustomproperty.cpp

@@ -11,4 +11,4 @@
 CFX_CSSCustomProperty::CFX_CSSCustomProperty(const CFX_CSSCustomProperty& prop)
     : name_(prop.name_), value_(prop.value_) {}
 
-CFX_CSSCustomProperty::~CFX_CSSCustomProperty() {}
+CFX_CSSCustomProperty::~CFX_CSSCustomProperty() = default;

diff --git a/core/fxcrt/css/cfx_cssdeclaration.cpp b/core/fxcrt/css/cfx_cssdeclaration.cpp
index 057ffab..5ef726b 100644
--- a/core/fxcrt/css/cfx_cssdeclaration.cpp
+++ b/core/fxcrt/css/cfx_cssdeclaration.cpp

@@ -139,7 +139,7 @@
 
 CFX_CSSDeclaration::CFX_CSSDeclaration() {}
 
-CFX_CSSDeclaration::~CFX_CSSDeclaration() {}
+CFX_CSSDeclaration::~CFX_CSSDeclaration() = default;
 
 RetainPtr<CFX_CSSValue> CFX_CSSDeclaration::GetProperty(
     CFX_CSSProperty eProperty,

diff --git a/core/fxcrt/css/cfx_cssenumvalue.cpp b/core/fxcrt/css/cfx_cssenumvalue.cpp
index c9b39be..f45a605 100644
--- a/core/fxcrt/css/cfx_cssenumvalue.cpp
+++ b/core/fxcrt/css/cfx_cssenumvalue.cpp

@@ -9,4 +9,4 @@
 CFX_CSSEnumValue::CFX_CSSEnumValue(CFX_CSSPropertyValue value)
     : CFX_CSSValue(CFX_CSSPrimitiveType::Enum), value_(value) {}
 
-CFX_CSSEnumValue::~CFX_CSSEnumValue() {}
+CFX_CSSEnumValue::~CFX_CSSEnumValue() = default;

diff --git a/core/fxcrt/css/cfx_cssnumbervalue.cpp b/core/fxcrt/css/cfx_cssnumbervalue.cpp
index d8f7247..f0c73cf 100644
--- a/core/fxcrt/css/cfx_cssnumbervalue.cpp
+++ b/core/fxcrt/css/cfx_cssnumbervalue.cpp

@@ -12,7 +12,7 @@
     value_ = 0.0f;
 }
 
-CFX_CSSNumberValue::~CFX_CSSNumberValue() {}
+CFX_CSSNumberValue::~CFX_CSSNumberValue() = default;
 
 float CFX_CSSNumberValue::Apply(float percentBase) const {
   switch (type_) {

diff --git a/core/fxcrt/css/cfx_csspropertyholder.cpp b/core/fxcrt/css/cfx_csspropertyholder.cpp
index 11e0d4b..ded7c92 100644
--- a/core/fxcrt/css/cfx_csspropertyholder.cpp
+++ b/core/fxcrt/css/cfx_csspropertyholder.cpp

@@ -8,4 +8,4 @@
 
 CFX_CSSPropertyHolder::CFX_CSSPropertyHolder() {}
 
-CFX_CSSPropertyHolder::~CFX_CSSPropertyHolder() {}
+CFX_CSSPropertyHolder::~CFX_CSSPropertyHolder() = default;

diff --git a/core/fxcrt/css/cfx_cssselector.cpp b/core/fxcrt/css/cfx_cssselector.cpp
index 492ec2e..61c4df8 100644
--- a/core/fxcrt/css/cfx_cssselector.cpp
+++ b/core/fxcrt/css/cfx_cssselector.cpp

@@ -32,7 +32,7 @@
     : m_eType(eType),
       m_dwHash(FX_HashCode_GetW(WideStringView(psz, iLen), bIgnoreCase)) {}
 
-CFX_CSSSelector::~CFX_CSSSelector() {}
+CFX_CSSSelector::~CFX_CSSSelector() = default;
 
 CFX_CSSSelectorType CFX_CSSSelector::GetType() const {
   return m_eType;

diff --git a/core/fxcrt/css/cfx_cssstringvalue.cpp b/core/fxcrt/css/cfx_cssstringvalue.cpp
index 6ff2a33..1c8fb5d 100644
--- a/core/fxcrt/css/cfx_cssstringvalue.cpp
+++ b/core/fxcrt/css/cfx_cssstringvalue.cpp

@@ -9,4 +9,4 @@
 CFX_CSSStringValue::CFX_CSSStringValue(const WideString& value)
     : CFX_CSSValue(CFX_CSSPrimitiveType::String), value_(value) {}
 
-CFX_CSSStringValue::~CFX_CSSStringValue() {}
+CFX_CSSStringValue::~CFX_CSSStringValue() = default;

diff --git a/core/fxcrt/css/cfx_cssstylerule.cpp b/core/fxcrt/css/cfx_cssstylerule.cpp
index 504771e..a30b994 100644
--- a/core/fxcrt/css/cfx_cssstylerule.cpp
+++ b/core/fxcrt/css/cfx_cssstylerule.cpp

@@ -8,7 +8,7 @@
 
 CFX_CSSStyleRule::CFX_CSSStyleRule() {}
 
-CFX_CSSStyleRule::~CFX_CSSStyleRule() {}
+CFX_CSSStyleRule::~CFX_CSSStyleRule() = default;
 
 size_t CFX_CSSStyleRule::CountSelectorLists() const {
   return m_ppSelector.size();

diff --git a/core/fxcrt/css/cfx_cssvaluelist.cpp b/core/fxcrt/css/cfx_cssvaluelist.cpp
index b96f165..3a8821a 100644
--- a/core/fxcrt/css/cfx_cssvaluelist.cpp
+++ b/core/fxcrt/css/cfx_cssvaluelist.cpp

@@ -13,7 +13,7 @@
 CFX_CSSValueList::CFX_CSSValueList(std::vector<RetainPtr<CFX_CSSValue>>& list)
     : CFX_CSSValue(CFX_CSSPrimitiveType::List), m_ppList(std::move(list)) {}
 
-CFX_CSSValueList::~CFX_CSSValueList() {}
+CFX_CSSValueList::~CFX_CSSValueList() = default;
 
 int32_t CFX_CSSValueList::CountValues() const {
   return m_ppList.size();

diff --git a/core/fxcrt/fx_bidi.cpp b/core/fxcrt/fx_bidi.cpp
index c5fb5c6..33f181d 100644
--- a/core/fxcrt/fx_bidi.cpp
+++ b/core/fxcrt/fx_bidi.cpp

@@ -74,7 +74,7 @@
     SetOverallDirectionRight();
 }
 
-CFX_BidiString::~CFX_BidiString() {}
+CFX_BidiString::~CFX_BidiString() = default;
 
 CFX_BidiChar::Direction CFX_BidiString::OverallDirection() const {
   ASSERT(m_eOverallDirection != CFX_BidiChar::NEUTRAL);

diff --git a/core/fxcrt/widestring.cpp b/core/fxcrt/widestring.cpp
index 10a31c3..2855cc9 100644
--- a/core/fxcrt/widestring.cpp
+++ b/core/fxcrt/widestring.cpp

@@ -383,7 +383,7 @@
   }
 }
 
-WideString::~WideString() {}
+WideString::~WideString() = default;
 
 WideString& WideString::operator=(const wchar_t* str) {
   if (!str || !str[0])