commit 148c14459dd25518b45bd65804709a0fc6ff6fda
author Tom Sepez <tsepez@chromium.org> Fri Jan 25 18:56:26 2019 +0000
committer Chromium commit bot <commit-bot@chromium.org> Fri Jan 25 18:56:26 2019 +0000
tree 88bc98f489ed12546eab888df8007cc3967311ee
parent d2acd6b9d1fdb441fff665c13f88483dbb5b1edf

Deprecate 7-Arg form of CFXA_Node constructor.

Its use has hidden some bugs in the past, and it is nice to
see the relationship between the CXFA_ and CJX_ classes expressed
explicitly in the code, since they are not 1:1.

Change-Id: Ib4ace6895a85fc8bc1f7af1642981337ac156ecf
Reviewed-on: https://pdfium-review.googlesource.com/c/48970
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Tom Sepez <tsepez@chromium.org>

xfa/fxfa/parser/cxfa_day.cpp

diff --git a/xfa/fxfa/parser/cxfa_day.cpp b/xfa/fxfa/parser/cxfa_day.cpp
index e3cd3a1..2953701 100644
--- a/xfa/fxfa/parser/cxfa_day.cpp
+++ b/xfa/fxfa/parser/cxfa_day.cpp
@@ -6,6 +6,9 @@
 
 #include "xfa/fxfa/parser/cxfa_day.h"
 
+#include "fxjs/xfa/cjx_node.h"
+#include "third_party/base/ptr_util.h"
+
 CXFA_Day::CXFA_Day(CXFA_Document* doc, XFA_PacketType packet)
     : CXFA_Node(doc,
                 packet,
@@ -13,6 +16,7 @@
                 XFA_ObjectType::ContentNode,
                 XFA_Element::Day,
                 nullptr,
-                nullptr) {}
+                nullptr,
+                pdfium::MakeUnique<CJX_Node>(this)) {}
 
 CXFA_Day::~CXFA_Day() = default;