commit 170ba1e9a962265d10126fd5788f489b3c698a6f
author Tom Sepez <tsepez@chromium.org> Thu Jun 13 22:35:04 2024 +0000
committer Pdfium LUCI CQ <pdfium-scoped@luci-project-accounts.iam.gserviceaccount.com> Thu Jun 13 22:35:04 2024 +0000
tree 996abbdc6b0f45c569f10cc25e265e02e8ace7cd
parent b009515fbdcab592c7683993de0f67e76df63668

Fix computation of y in GetAP_Check().

The original code (e.g. ver 3f3b45cc74b0499912409f766a595945dbbfc4c5)
was:
                pts[j].y *= fHeight;
                pts[j].y += crBBox.bottom;

This is a longstanding issue introduced in
  https://codereview.chromium.org/1566583002

Change-Id: I6cb323cd7afad97462695d992761aed8a220ce07
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/120492
Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Thomas Sepez <tsepez@google.com>
Commit-Queue: Tom Sepez <tsepez@chromium.org>

fpdfsdk/cpdfsdk_appstream.cpp

diff --git a/fpdfsdk/cpdfsdk_appstream.cpp b/fpdfsdk/cpdfsdk_appstream.cpp
index 9bea26f..40e0402 100644
--- a/fpdfsdk/cpdfsdk_appstream.cpp
+++ b/fpdfsdk/cpdfsdk_appstream.cpp
@@ -208,7 +208,7 @@
     for (size_t j = 0; j < std::size(pts[0]); ++j) {
       UNSAFE_TODO({
         pts[i][j].x = pts[i][j].x * fWidth + crBBox.left;
-        pts[i][j].y *= pts[i][j].y * fHeight + crBBox.bottom;
+        pts[i][j].y = pts[i][j].y * fHeight + crBBox.bottom;
       });
     }
   }