commit 17201fb9fb2aebdf636e259b69764f8897c9db13
author Lei Zhang <thestig@chromium.org> Mon May 19 16:08:34 2025 -0700
committer Pdfium LUCI CQ <pdfium-scoped@luci-project-accounts.iam.gserviceaccount.com> Mon May 19 16:08:34 2025 -0700
tree 21af16e0fcb71ca33481260101eb0ed72ff9b5af
parent f40f993d3334b67be5f47cb340e589f04071b84f

Rename CJS_Document::getPropertyInternal()

Rename to GetPropertyInternal() to follow the style guide.

Change-Id: Idbab4c3dbd7744d8d41c31fc5ad0d9b9b2bbdb92
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/132050
Commit-Queue: Lei Zhang <thestig@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>

fxjs/cjs_document.cpp

diff --git a/fxjs/cjs_document.cpp b/fxjs/cjs_document.cpp
index 852e2c8..3fbad4b 100644
--- a/fxjs/cjs_document.cpp
+++ b/fxjs/cjs_document.cpp
@@ -697,7 +697,7 @@
 }
 
 CJS_Result CJS_Document::get_author(CJS_Runtime* pRuntime) {
-  return getPropertyInternal(pRuntime, "Author");
+  return GetPropertyInternal(pRuntime, "Author");
 }
 
 CJS_Result CJS_Document::set_author(CJS_Runtime* pRuntime,
@@ -773,7 +773,7 @@
   return CJS_Result::Failure(JSMessage::kReadOnlyError);
 }
 
-CJS_Result CJS_Document::getPropertyInternal(CJS_Runtime* pRuntime,
+CJS_Result CJS_Document::GetPropertyInternal(CJS_Runtime* pRuntime,
                                              ByteStringView property_name) {
   if (!form_fill_env_) {
     return CJS_Result::Failure(JSMessage::kBadObjectError);
@@ -790,7 +790,7 @@
 }
 
 CJS_Result CJS_Document::get_creation_date(CJS_Runtime* pRuntime) {
-  return getPropertyInternal(pRuntime, "CreationDate");
+  return GetPropertyInternal(pRuntime, "CreationDate");
 }
 
 CJS_Result CJS_Document::set_creation_date(CJS_Runtime* pRuntime,
@@ -800,7 +800,7 @@
 }
 
 CJS_Result CJS_Document::get_creator(CJS_Runtime* pRuntime) {
-  return getPropertyInternal(pRuntime, "Creator");
+  return GetPropertyInternal(pRuntime, "Creator");
 }
 
 CJS_Result CJS_Document::set_creator(CJS_Runtime* pRuntime,
@@ -843,7 +843,7 @@
 }
 
 CJS_Result CJS_Document::get_keywords(CJS_Runtime* pRuntime) {
-  return getPropertyInternal(pRuntime, "Keywords");
+  return GetPropertyInternal(pRuntime, "Keywords");
 }
 
 CJS_Result CJS_Document::set_keywords(CJS_Runtime* pRuntime,
@@ -853,7 +853,7 @@
 }
 
 CJS_Result CJS_Document::get_mod_date(CJS_Runtime* pRuntime) {
-  return getPropertyInternal(pRuntime, "ModDate");
+  return GetPropertyInternal(pRuntime, "ModDate");
 }
 
 CJS_Result CJS_Document::set_mod_date(CJS_Runtime* pRuntime,
@@ -863,7 +863,7 @@
 }
 
 CJS_Result CJS_Document::get_producer(CJS_Runtime* pRuntime) {
-  return getPropertyInternal(pRuntime, "Producer");
+  return GetPropertyInternal(pRuntime, "Producer");
 }
 
 CJS_Result CJS_Document::set_producer(CJS_Runtime* pRuntime,
@@ -873,7 +873,7 @@
 }
 
 CJS_Result CJS_Document::get_subject(CJS_Runtime* pRuntime) {
-  return getPropertyInternal(pRuntime, "Subject");
+  return GetPropertyInternal(pRuntime, "Subject");
 }
 
 CJS_Result CJS_Document::set_subject(CJS_Runtime* pRuntime,
@@ -886,7 +886,7 @@
   if (!form_fill_env_) {
     return CJS_Result::Failure(JSMessage::kBadObjectError);
   }
-  return getPropertyInternal(pRuntime, "Title");
+  return GetPropertyInternal(pRuntime, "Title");
 }
 
 CJS_Result CJS_Document::set_title(CJS_Runtime* pRuntime,

fxjs/cjs_document.h

diff --git a/fxjs/cjs_document.h b/fxjs/cjs_document.h
index 87585de..3e09ea4 100644
--- a/fxjs/cjs_document.h
+++ b/fxjs/cjs_document.h
@@ -299,7 +299,7 @@
   CJS_Result removeIcon(CJS_Runtime* pRuntime,
                         pdfium::span<v8::Local<v8::Value>> params);
 
-  CJS_Result getPropertyInternal(CJS_Runtime* pRuntime,
+  CJS_Result GetPropertyInternal(CJS_Runtime* pRuntime,
                                  ByteStringView property_name);
 
   CPDF_InteractiveForm* GetCoreInteractiveForm();