commit 197d4986eeee11c7e02d00dbf517bb54b525b3af
author Lei Zhang <thestig@chromium.org> Fri Aug 09 21:40:49 2019 +0000
committer Chromium commit bot <commit-bot@chromium.org> Fri Aug 09 21:40:49 2019 +0000
tree 71af360842409b226dcfb89c171aa69de62063e6
parent 196557544923876c60ba0a1adb325c0c45144174

Simplify code that deals with CPDF_PageObjectHolder::GetDict().

CPDF_PageObjectHolder::GetDict() never returns nullptr, so remove all
the code that assumes it can.

Change-Id: Ia34e79c12052e86175df60cd600e360c9f6155b0
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/59112
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>

fpdfsdk/fpdf_doc.cpp

diff --git a/fpdfsdk/fpdf_doc.cpp b/fpdfsdk/fpdf_doc.cpp
index b9bf93d..5b7c727 100644
--- a/fpdfsdk/fpdf_doc.cpp
+++ b/fpdfsdk/fpdf_doc.cpp
@@ -343,7 +343,7 @@
   if (!start_pos || !link_annot)
     return false;
   CPDF_Page* pPage = CPDFPageFromFPDFPage(page);
-  if (!pPage || !pPage->GetDict())
+  if (!pPage)
     return false;
   CPDF_Array* pAnnots = pPage->GetDict()->GetArrayFor("Annots");
   if (!pAnnots)