commit 1be28d1b037de32c75632e10e7d2fc758fe7f962
author Jun Fang <jun_fang@foxitsoftware.com> Mon Feb 01 20:18:32 2016 -0800
committer Jun Fang <jun_fang@foxitsoftware.com> Mon Feb 01 20:18:32 2016 -0800
tree bc168cc814ad3888f9890d6a518a25d40f73fcdf
parent a74710b8d189ba2c37feab64f0eebc2f96e77382

Fix a crashier in CPDFSDK_Document::GetPageView()

XFA document should be released before SDK document is
released.

BUG=pdfium:369
R=tsepez@chromium.org

Review URL: https://codereview.chromium.org/1652883002 .

fpdfsdk/src/fpdfxfa/fpdfxfa_doc.cpp

diff --git a/fpdfsdk/src/fpdfxfa/fpdfxfa_doc.cpp b/fpdfsdk/src/fpdfxfa/fpdfxfa_doc.cpp
index d37038d..7c2bbf0 100644
--- a/fpdfsdk/src/fpdfxfa/fpdfxfa_doc.cpp
+++ b/fpdfsdk/src/fpdfxfa/fpdfxfa_doc.cpp
@@ -45,11 +45,16 @@
 }
 
 CPDFXFA_Document::~CPDFXFA_Document() {
-  if (m_pJSContext && m_pSDKDoc && m_pSDKDoc->GetEnv())
-    m_pSDKDoc->GetEnv()->GetJSRuntime()->ReleaseContext(m_pJSContext);
-
-  delete m_pSDKDoc;
-
+  if (m_pXFADoc) {
+    IXFA_App* pApp = m_pApp->GetXFAApp();
+    if (pApp) {
+      IXFA_DocHandler* pDocHandler = pApp->GetDocHandler();
+      if (pDocHandler)
+        CloseXFADoc(pDocHandler);
+    }
+    delete m_pXFADoc;
+    m_pXFADoc = nullptr;
+  }
   if (m_pPDFDoc) {
     CPDF_Parser* pParser = m_pPDFDoc->GetParser();
     if (pParser)
@@ -57,16 +62,9 @@
     else
       delete m_pPDFDoc;
   }
-  if (m_pXFADoc) {
-    IXFA_App* pApp = m_pApp->GetXFAApp();
-    if (pApp) {
-      IXFA_DocHandler* pDocHandler = pApp->GetDocHandler();
-      if (pDocHandler) {
-        CloseXFADoc(pDocHandler);
-      }
-    }
-    delete m_pXFADoc;
-  }
+  if (m_pJSContext && m_pSDKDoc && m_pSDKDoc->GetEnv())
+    m_pSDKDoc->GetEnv()->GetJSRuntime()->ReleaseContext(m_pJSContext);
+  delete m_pSDKDoc;
 }
 
 FX_BOOL CPDFXFA_Document::LoadXFADoc() {
@@ -487,7 +485,6 @@
   if (!pPage)
     return;
   pPage->SetXFAPageView(nullptr);
-  m_pSDKDoc->GetPageView(pPage)->ClearFXAnnots();
 }
 
 void CPDFXFA_Document::WidgetEvent(IXFA_Widget* hWidget,