commit 1f893991fff0ec1549143592f1c6006f7be828c4
author Lei Zhang <thestig@chromium.org> Fri Jan 31 00:20:24 2020 +0000
committer Chromium commit bot <commit-bot@chromium.org> Fri Jan 31 00:20:24 2020 +0000
tree aadabb9ecc4ef7b9ae0384747b829f9195e1582b
parent 21f9e7c053096d553f71d51b556af22e1ded93aa

Rename CPDFSDK_FormFillEnvironment::GetPermissions().

GetPermissions() returns a bool rather than the actual permission value,
so rename it to HasPermissions().

Change-Id: Ifae4fb98b3ac0bf4d91755ab6d45181d6bad0398
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/65619
Commit-Queue: Lei Zhang <thestig@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>

fpdfsdk/cpdfsdk_formfillenvironment.cpp

diff --git a/fpdfsdk/cpdfsdk_formfillenvironment.cpp b/fpdfsdk/cpdfsdk_formfillenvironment.cpp
index c6c2e4f..feeb2b4 100644
--- a/fpdfsdk/cpdfsdk_formfillenvironment.cpp
+++ b/fpdfsdk/cpdfsdk_formfillenvironment.cpp
@@ -744,6 +744,6 @@
   return pExtension ? pExtension->GetPageCount() : m_pCPDFDoc->GetPageCount();
 }
 
-bool CPDFSDK_FormFillEnvironment::GetPermissions(uint32_t flags) const {
+bool CPDFSDK_FormFillEnvironment::HasPermissions(uint32_t flags) const {
   return !!(m_pCPDFDoc->GetUserPermissions() & flags);
 }

fpdfsdk/cpdfsdk_formfillenvironment.h

diff --git a/fpdfsdk/cpdfsdk_formfillenvironment.h b/fpdfsdk/cpdfsdk_formfillenvironment.h
index 12119c7..71a4fa8 100644
--- a/fpdfsdk/cpdfsdk_formfillenvironment.h
+++ b/fpdfsdk/cpdfsdk_formfillenvironment.h
@@ -79,7 +79,7 @@
 
   // See PDF Reference 1.7, table 3.20 for the permission bits. Returns true if
   // any bit in |flags| is set.
-  bool GetPermissions(uint32_t flags) const;
+  bool HasPermissions(uint32_t flags) const;
 
   bool GetChangeMark() const { return m_bChangeMask; }
   void SetChangeMark() { m_bChangeMask = true; }

fpdfsdk/formfiller/cffl_interactiveformfiller.cpp

diff --git a/fpdfsdk/formfiller/cffl_interactiveformfiller.cpp b/fpdfsdk/formfiller/cffl_interactiveformfiller.cpp
index 6766e1c..bf49dc8 100644
--- a/fpdfsdk/formfiller/cffl_interactiveformfiller.cpp
+++ b/fpdfsdk/formfiller/cffl_interactiveformfiller.cpp
@@ -472,9 +472,9 @@
   if (pWidget->GetFieldType() == FormFieldType::kPushButton)
     return false;
 
-  return m_pFormFillEnv->GetPermissions(FPDFPERM_FILL_FORM) ||
-         m_pFormFillEnv->GetPermissions(FPDFPERM_ANNOT_FORM) ||
-         m_pFormFillEnv->GetPermissions(FPDFPERM_MODIFY);
+  return m_pFormFillEnv->HasPermissions(FPDFPERM_FILL_FORM) ||
+         m_pFormFillEnv->HasPermissions(FPDFPERM_ANNOT_FORM) ||
+         m_pFormFillEnv->HasPermissions(FPDFPERM_MODIFY);
 }
 
 CFFL_FormFiller* CFFL_InteractiveFormFiller::GetFormFiller(