commit 2120c855be0c567cbee40f6d6b9564e9f7579b8d
author Tom Sepez <tsepez@chromium.org> Thu Oct 28 23:34:26 2021 +0000
committer Pdfium LUCI CQ <pdfium-scoped@luci-project-accounts.iam.gserviceaccount.com> Thu Oct 28 23:34:26 2021 +0000
tree 6606d990ca97dd357342fc60c2164f56d4a5670c
parent a5e9be6da96c4a81e6710197800c4b7bf3705a7b

Remove arg from CPDFSDK_FormFillEnvironment::UpdateAllViews()

All callers pass `pSender` as nullptr.

Change-Id: Ie49e4f33c281b28e860fb005dcd3d7bf824b0652
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/86590
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Tom Sepez <tsepez@chromium.org>

fpdfsdk/cpdfsdk_formfillenvironment.cpp

diff --git a/fpdfsdk/cpdfsdk_formfillenvironment.cpp b/fpdfsdk/cpdfsdk_formfillenvironment.cpp
index d4b3634..e52b96f 100644
--- a/fpdfsdk/cpdfsdk_formfillenvironment.cpp
+++ b/fpdfsdk/cpdfsdk_formfillenvironment.cpp
@@ -730,11 +730,10 @@
   return m_pInteractiveForm.get();
 }
 
-void CPDFSDK_FormFillEnvironment::UpdateAllViews(CPDFSDK_PageView* pSender,
-                                                 CPDFSDK_Annot* pAnnot) {
+void CPDFSDK_FormFillEnvironment::UpdateAllViews(CPDFSDK_Annot* pAnnot) {
   for (const auto& it : m_PageMap) {
     CPDFSDK_PageView* pPageView = it.second.get();
-    if (pPageView != pSender)
+    if (pPageView)
       pPageView->UpdateView(pAnnot);
   }
 }

fpdfsdk/cpdfsdk_formfillenvironment.h

diff --git a/fpdfsdk/cpdfsdk_formfillenvironment.h b/fpdfsdk/cpdfsdk_formfillenvironment.h
index 9c70644..9fb5851 100644
--- a/fpdfsdk/cpdfsdk_formfillenvironment.h
+++ b/fpdfsdk/cpdfsdk_formfillenvironment.h
@@ -86,7 +86,7 @@
 
   CPDFSDK_PageView* GetPageViewAtIndex(int nIndex);
   void RemovePageView(IPDF_Page* pUnderlyingPage);
-  void UpdateAllViews(CPDFSDK_PageView* pSender, CPDFSDK_Annot* pAnnot);
+  void UpdateAllViews(CPDFSDK_Annot* pAnnot);
 
   bool KillFocusAnnot(Mask<FWL_EVENTFLAG> nFlag);
   void ClearAllFocusedAnnots();

fxjs/cjs_field.cpp

diff --git a/fxjs/cjs_field.cpp b/fxjs/cjs_field.cpp
index e6addf8..a6abf74 100644
--- a/fxjs/cjs_field.cpp
+++ b/fxjs/cjs_field.cpp
@@ -96,7 +96,7 @@
       if (pObserved) {
         CPDFSDK_Widget* pWidget = ToCPDFSDKWidget(pObserved.Get());
         pWidget->GetInteractiveForm()->GetFormFillEnv()->UpdateAllViews(
-            nullptr, pWidget);
+            pWidget);
       }
     }
   }
@@ -135,7 +135,7 @@
 
     if (bRefresh) {
       CPDFSDK_InteractiveForm* pWidgetForm = pWidget->GetInteractiveForm();
-      pWidgetForm->GetFormFillEnv()->UpdateAllViews(nullptr, pWidget);
+      pWidgetForm->GetFormFillEnv()->UpdateAllViews(pWidget);
     }
   }